Comments (5)
I tried to add a clarification about the coordinate system earlier in commit b88f788 – perhaps you're working on an older version of the exercises? Apologies for the confusion and I'd be glad to make this even clearer if you have a suggestion!
from haskell-mooc.
I think the test has adapted, see 5bb4294.
from haskell-mooc.
@muzimuzhi Thank you for linking that commit - it helps understand the situation better.
Another interesting bit is that the test file has this line of code for the given exercise (which I had wrongly marked as exercise 4 instead of exercise 3, fixed now!) - conjoin [checkShape x y True rect | x <- [x0..x0+w-1], y <- [y0..y0+h-1]]
So it it does take values in the range [x0, x0+w)
and [y0, y0+h)
. So my assumption was right, and as per your commit link, they did have the intention of modifying the expectation to be that of a rectangle whose upper-left coordinates are given, but in the "screen coordinate system".
I think the text of the question should be updated to make it consistent - either mention that this is the "screen coordinate/graphics coordinate system" with the given coordinates as the upper-left corner of the rectangle, or that the given coordinates are for the bottom-left corner (assuming the normal Euclidean coordinate system).
from haskell-mooc.
I tried to add a clarification about the coordinate system earlier in commit b88f788 – perhaps you're working on an older version of the exercises? Apologies for the confusion and I'd be glad to make this even clearer if you have a suggestion!
Thank you for clearing that up! I must admit that it's my mistake as I had not read that part at all. I should have read the comments in the exercises in order.
Since the comment explains the coordinate system in use, I don't think there is really anything that should be changed (especially seeing as to how no else has mentioned it), so I'll close the issue now.
Thanks for the help, @muzimuzhi and @opqdonut, and sorry for the unnecessary confusion! :-)
from haskell-mooc.
Closing since it is a non-issue. The comments in the file mentions how the coordinate system is supposed to work, and I failed to read it.
from haskell-mooc.
Related Issues (20)
- Stack build fails HOT 2
- Add Hacktoberfest label HOT 1
- Update the packages to modern Haskell HOT 8
- Set14b.hs does not load in GHCI HOT 2
- Missing tests for prettyPrint, Part 1, Set 5a, Ex. 12. HOT 1
- Add fmap tests for Set 13b Exercise 7 HOT 1
- Data.Traversable forbidden on haskell.mooc.fi yet not forbidden in haskell-mooc/exercises/Set11aTest.hs HOT 2
- Lecture 3 Quiz HOT 1
- Make quizzes more accessible to colorblind users HOT 1
- Encountered an error related to ffi.h while building the project on Apple Silicon macOS Ventura 13.3.1 HOT 2
- Minor typo in lecture 3.9
- Set14bTest.hs doesn't close the database connection which leads to incorrect testing HOT 1
- Ex 6 of Set4a.hs HOT 2
- Exercise 8.3 ambiguous definition HOT 1
- Submission fails with factory code HOT 4
- 2.3.1 List Operations: missing `last` HOT 3
- Three different versions of GHCi found in interactive `stack ghci`
- Use HTTPS for external links when possible (round 2) HOT 3
- Set 7 Ex 8 Passes locally, but not on the website HOT 2
- stack build fails, hspec missing dependency libtinfo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haskell-mooc.