Comments (4)
I'm happy for you to use any of the code (that's why its got a MIT licence!). I'm equally happy to take patches to fix bugs (and RFC incompatibilities are bugs).
I was aware that escapeString()
was a very simple implementation - its why I use encodeString()
to send to the server. Looking at the RFC, I think that Cyrus is wrong not to accept literal-c2s as the grammar says that "string" is quoted-string, literal-c2s or literal-s2c. On the other hand, since either string representation should work, I can't see an objection to using quoted string (other than the brain-deadness of my escapeString()
implementation). I'm testing against dovecot, if that makes any difference....
Netbeans claims to support Maven, although I've never used it. There's already a Mavenised fork here on GitHub but I've never tried it, so don't let me stop you doing your own.
Using tabs instead of spaces may be a dealbreaker :-). (On the other hand, I can re-format anything you send back, so don't worry about it).
I'd suggest you open a bunch of issues for the separate things you've listed, and I'll close this one.
Thanks for the interest in my project!
from managesievej.
On Fri, Feb 27, 2015 at 9:59 AM, Osric Wilkinson [email protected]
wrote:
I'm happy for you to use any of the code (that's why its got a MIT
licence!). I'm equally happy to take patches to fix bugs (and RFC
incompatibilities are bugs).
I was aware that escapeString() was a very simple implementation - its
why I use encodeString() to send to the server. Looking at the RFC, I
think that Cyrus is wrong not to accept literal-c2s as the grammar says
that "string" is quoted-string, literal-c2s or literal-s2c.
The RFC also states "This type of literal can only be sent from the server
to the client" when describing literal-s2c. So Dovecot is not compliant in
this regard.
On the other hand, since either string representation should work, I can't
see an objection to using quoted string (other than the brain-deadness of
my escapeString() implementation). I'm testing against dovecot, if that
makes any difference....
Netbeans claims to support Maven, although I've never used it. There's
already a Mavenised fork here on GitHub but I've never tried it, so don't
let me stop you doing your own.This is actually an important point. Maven expects the code to be in
src/main/java (see the standard directory layout:
http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html).
This impacts the submission of patches. However, if moving the files is an
issue for you, it should be possible to patch the pom.xml file to point to
src instead of src/main/java.Using tabs instead of spaces may be a dealbreaker :-). (On the other hand,
I can re-format anything you send back, so don't worry about it).Ideally, we would like to see a mavenized ManageSieveJ released on
mvnrepository. This would mean we don't need to keep a fork-with-tabs in
our tree, we could just pull ManageSieveJ as a dependency.I'd suggest you open a bunch of issues for the separate things you've
listed, and I'll close this one.
Thanks for the interest in my project!You're welcome. Thanks for making the code available in the first place.
from managesievej.
Phew! That was a bunch of stuff. I've applied your patches (and thanks again for those), and I'm getting setup to add the project to Maven Central. Anything else on your wishlist?
from managesievej.
That will be all. Thanks for the amazing (and fast) job.
from managesievej.
Related Issues (14)
- setActive can only make only one script active. HOT 2
- GETSCRIPT should handle a NO/BYE answer from the server HOT 1
- Remove a warning in ParseException HOT 1
- Update copyright
- RFC-compliant quoted string representation HOT 1
- Socket timeout HOT 2
- putscript with utf-8 chars HOT 1
- NullPointerException when calling ManageSieveClient#isConnected before ManageSieveClient#connect HOT 1
- Get script parsing having issues when characters with ascii > 'z' appear in the sieve file. HOT 8
- Maven compatibility HOT 1
- Make it possible to authenticate on behalf of another user HOT 1
- Use the literal-c2s string representation from RFC 5804 HOT 1
- Cyrus compatibility HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from managesievej.