Giter Site home page Giter Site logo

Comments (9)

cpojer avatar cpojer commented on August 24, 2024

Why is this a problem exactly?

from mootools-core.

simonklb avatar simonklb commented on August 24, 2024

For example <form action></form> sends you to http://domain.com/null while <form action=""></form> sends you to the same page.

from mootools-core.

jdalton avatar jdalton commented on August 24, 2024

nice find!

from mootools-core.

subtleGradient avatar subtleGradient commented on August 24, 2024

Yup. Definitely an issue. Should be a pretty easy fix I would assume

from mootools-core.

arian avatar arian commented on August 24, 2024

@subtleGradient how?

form.setAttribute('action', ''); // → <form action></form>

// or maybe?

var attr = document.createAttribute('action');
attr.nodeValue = '';
form.setAttributeNode(attr); // → <form action></form>

So how did you want to fix this?

from mootools-core.

Inviz avatar Inviz commented on August 24, 2024

While we're there, does Slick.match(new Element('input[disabled]'), 'input[disabled]') still return false? Boolean (empty) attributes did not call setAttribute, and Slick doesnt read the property

from mootools-core.

arian avatar arian commented on August 24, 2024

@Inviz seems to work fine: http://jsfiddle.net/YBcUs/1/

from mootools-core.

Inviz avatar Inviz commented on August 24, 2024

@arian Even if your example does not create element with mootools, i checked it myself now, and it works with the edge mootools. I guess, i just need to update. Thanks anyways!

from mootools-core.

ibolmo avatar ibolmo commented on August 24, 2024

Updated the fiddle and looks like the attribute does have an empty string: http://jsfiddle.net/ubLw5/2/ for all browsers I've tested (FFx, IE, Safari, Chrome, ...)

So.. worksforme. You're probably seeing the attribute as <div attribute> because of the developer tools vs Firebug it'll show the empty string.

Re-open the issue, if you can provide a better test case.

from mootools-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.