Giter Site home page Giter Site logo

Namespace support about gokogiri HOT 6 CLOSED

moovweb avatar moovweb commented on July 19, 2024
Namespace support

from gokogiri.

Comments (6)

jhinrichsen avatar jhinrichsen commented on July 19, 2024

A draft implementation is happily humming along. I do not have a clean pull request at hand, because in addition to the namespace extension i had to (1) change include path for darwin/x64 and (2) remove any reference to time/ Deadline related code that i found broke.

Please feel free to have a look at the new ns.go file (not sure if all the interface stuff is needed, i just borrowed heavily from Node/ XmlNode), the new function in node.go, and the new testcase in attribute_test.go.

The change should be transparent to existing clients.

from gokogiri.

zhigangc avatar zhigangc commented on July 19, 2024

Thanks for your contribution, Jochen. I will review it and get back to you.

Yes, the Deadline related code was intended for internal use. I will create a separate public repo very soon.

from gokogiri.

rzymek avatar rzymek commented on July 19, 2024

Any news of the subject?
I've just stumbled upon the lack of AttributeNode.Namespace() while writing an Inkscape SVG cleaner.

from gokogiri.

mdayaram avatar mdayaram commented on July 19, 2024

Sorry, the project has been passed to different hands, so this issue was lost in the wayside. Regardless, I don't think there's any future plans for implementing namespace support for attributes from our side. However, if @jhinrichsen has a PR ready, I'll gladly look at it and merge it if it's good to go.

from gokogiri.

jbowtie avatar jbowtie commented on July 19, 2024

This looks to have been fixed by pull requests #37 and #38

from gokogiri.

mdayaram avatar mdayaram commented on July 19, 2024

True that. @rzymek, does the new Namespace API meet your needs?

from gokogiri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.