crash when mopidy local is disabled

[mopidy]

crash when mopidy local is disabled

[jodal]

Mopidy-Local-SQLite is just a library extension to Mopidy-Local itself, thus Mopidy-Local must also be activated for Mopidy-Local-SQLite to work.

[jodal]

That said, Mopidy-Local-SQLite could try to handle this nicer, e.g. by checking in Extension.validate_environment() that the Mopidy-Local config is present. If the Mopidy-Local extension is disabled, the matching config won't be available, IIRC.

[woutervanwijk]

I know, but if I disable one extension, another one that is installed shouldn't crash mopidy, imho. It should just do nothing. Or mopidy should check if an extension depends on another and disable the child-extension if the parent is disabled?

[jodal]

Agree. Mopidy doesn't know anything about the extension relations, so it must be the child extension that checks in Extensions.validate_environment() if the parent extension is available, and if not, raise the proper exception so it is disabled too.

[tkem]

Agreed. Maybe that's something that should also go into the Mopidy docs, in the "Extension Development" section?

[jodal]

Hum, you don't have access to the config at the time of Extension.validate_environment(), so one needs to fail the extension at a later point. For a regular frontend, I'd simply raise FrontendError from the frontend's __init__(). For a local library, it should be possible to do something similar.

[tkem]

AFIACS, what this whole issue really boils down is that an exception in a Web application's factory method will go unhandled, and will prevent Mopidy's Web server from being started. IMHO, exceptions from the factory methods registered via http:app should be caught in HttpServer._get_app_request_handlers(), and the corresponding Web app should be disabled without affecting other Web applications. However, I'll provide a workaround for this special case in Mopidy-Local-SQLite, ASAP.