Comments (8)
In addition to this, I closed #97 because having dedicated interfaces for each abstract bundler would be error-prone: bundler functions should not be called directly
from morpho-blue-bundlers.
I agree with just putting a comment. Users should generally not be interacting with the contracts directly anyway.
from morpho-blue-bundlers.
Adding those modifiers means that we're not sure about the security of bundlers in some way, no?
from morpho-blue-bundlers.
These modifiers would only have the goal of protecting the user, as I stated in the description of this issue ; I don't see why adding them means we're not sure about the security of bundlers?
from morpho-blue-bundlers.
I'm not sure what you mean by "unexpected behaviors of the bundlers" then. Can you elaborate on that please?
from morpho-blue-bundlers.
When calling the bundler without going through multicall
:
_initiator
is uninitialized whereas it's used inside functions- you can't provide ETH to the call (functions are not payable)
from morpho-blue-bundlers.
So there's 2 paths:
- Either we write a comment tellings users to pass though the multicall only
- Add this modifier to protect users
2 is not necessary but does not add much gas cost either. 1 could be sufficient and does not add more complexity.
@morpho-labs/onchain thoughts?
from morpho-blue-bundlers.
I agree with Patrick. These contracts are not meant to be used by users who know how to use/write smart contracts anyway
from morpho-blue-bundlers.
Related Issues (20)
- Fix issue with URD v1.0.0 solc version
- Update tag
- Check for functions signatures clash
- harmonise compilation of libs
- submodules point to morpho-labs org
- rename bundlerV2
- improvements of the graph in the README HOT 1
- No correct setup when running `forge create`
- inconsistent and misleading name
- Add a tag & release for the new version
- Bundler for L2
- Inconsistent naming of "MainnetLib" HOT 5
- Gas testing with forge
- Harmonize EthereumBundler
- Link to deployments in the README
- Improve multi-chain testing
- Avoid needing SepoliaBundler
- Issue in test chain setup
- Try mermaid again
- Re-verify contract on etherscan
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morpho-blue-bundlers.