Giter Site home page Giter Site logo

Comments (6)

mountainMath avatar mountainMath commented on August 24, 2024

Totally agree. Much better way of handling things. And jsonlite does exactly the right thing:

regions = list(PR = c("59"))
jsonlite::toJSON(regions)

yields

{"PR":["59"]} 

from cancensus.

atheriel avatar atheriel commented on August 24, 2024

It looks like it also does the right thing in the likely case, which is when users don't wrap arguments in c():

> jsonlite::toJSON(list(PR = "35", CMA = c("59155", "59255")))
# {"PR":["35"],"CMA":["59155","59255"]} 

from cancensus.

atheriel avatar atheriel commented on August 24, 2024

I'll take a crack at implementing this shortly.

from cancensus.

mountainMath avatar mountainMath commented on August 24, 2024

Can we type-check if "regions" is a string and just continue as before in that case? Not really much extra work and the cold falls back gracefully while we transition over the function calls. We could put in a depreciation warning and phase it out in a couple of weeks.

from cancensus.

atheriel avatar atheriel commented on August 24, 2024

@mountainMath I've implemented this in #29.

from cancensus.

mountainMath avatar mountainMath commented on August 24, 2024

Merged PR #29

from cancensus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.