Giter Site home page Giter Site logo

Comments (3)

chmac avatar chmac commented on May 17, 2024

I forked the repo and started some experiments. On reflection, I don't think this approach makes sense. There's so much formatting and so on in the transport, that I guess it makes more sense to simply create my own transport in my app. I might also publish that as a package, not sure yet.

Expo doesn't have an appendFile, so I'll likely shard the files by date and so on as well.

from react-native-logs.

alessandro-bottamedi avatar alessandro-bottamedi commented on May 17, 2024

Thanks for the appreciation :), I don't really know how expo-fs works but i think the best idea is to create a new transport, it's the easiest way to do it.

If you create your transport with expo-fs then we can integrate it in the package

from react-native-logs.

chmac avatar chmac commented on May 17, 2024

@alessandro-bottamedi I tried this approach this morning, just pushed the branch if you want to check it out. The approach worked locally. But the dependency on expo-file-system is invisible, which I'm not quite sure about. I guess it would make sense to publish transports which have dependencies as their own packages, so they're tracked separately.

I didn't end up using expo-fs as it's just another layer of abstraction which wasn't necessary in this case. If you want to add the expoFileSystem transport into core, the code I pushed might work.

I also added a prettier configuration and some other stuff, but I haven't pushed any of that. I'm leaning more and more towards my own app specific transport.

from react-native-logs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.