Giter Site home page Giter Site logo

Comments (9)

ahunt avatar ahunt commented on May 26, 2024 1

Voila:
error3

from focus-android.

ahunt avatar ahunt commented on May 26, 2024

@antlam : do you have any design plans for error pages? I've made a 1:1 copy of the iOS error page for now.

We'll probably need to provide our own error text, if we want to support API 21+ we only get messages like "net::ERR_NAME_NOT_RESOLVED". (API 23+ provides another callback which supplies strings such as "There was a network error." Even that is quite useless, since we know ERROR_HOST_LOOKUP is a DNS error, and not just a network error.)

from focus-android.

antlam avatar antlam commented on May 26, 2024

I was thinking we should just use the same error pages we currently have in Fennec. Minus the "Search" box and maybe the "Enable Wi-Fi" button?

But instead of a light grey background, just use the private browsing grey #363B40 as the background, but use white text.

Thoughts?

from focus-android.

ahunt avatar ahunt commented on May 26, 2024

If we use the fennec pages, we could import all the strings 1:1 from fennec (which would save localisation effort), but the search boxes and wifi buttons seem to be hardcoded into the translateable content which makes that a bit harder.

Here's a list of all the strings that fennec uses:
https://dxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/overrides/netError.dtd

from focus-android.

ahunt avatar ahunt commented on May 26, 2024

Current status: (it's hard to get a good screenshot with the urlbar also visible because of the scrolling bug)
focus_error

from focus-android.

antlam avatar antlam commented on May 26, 2024

Nice! @ahunt Can we make the button the same blue that's in our Settings?

from focus-android.

ahunt avatar ahunt commented on May 26, 2024

@antlam:
focus_error2

from focus-android.

antlam avatar antlam commented on May 26, 2024

@ahunt final nit - can we remove that / / / / / / / image but keep the same spacing? That is "Server not found" should stay in the same position.

from focus-android.

antlam avatar antlam commented on May 26, 2024

Ship it!

from focus-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.