Giter Site home page Giter Site logo

Comments (3)

bhearsum avatar bhearsum commented on July 17, 2024

I was talking to @rail about this and he pointed out that none of the UI interactions use backend endpoints that require auth. So we can just rip out the frontend login stuff instead of trying to fix it. I'm guessing it only exists because this used to be integrated with the common releng frontend code in the services repo.

from tooltool.

bhearsum avatar bhearsum commented on July 17, 2024

I was poking at unrelated things today and realized that downloads of internal artifacts from the UI don't work if you're not logged in. I can't confirm that they do work if you are logged in, but presumably a session cookie would be set in that case, and they would.

So, now I'm not sure whether or not we can rip out logins.

from tooltool.

bhearsum avatar bhearsum commented on July 17, 2024

I ended up making logins work, but internal artifact downloads still do not. This is because the links to them are simple tags, which can't include an Authorization header. I think it's possible to change the frontend to download with an XHR request after a bit of research, but I don't know if it's worthwhile.

from tooltool.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.