Comments (4)
Thinking more about this - I'm not convinced this would be the right approach. Do we really want something that does validation in a request?
I don't know how the current setup works precisely but shouldn't validation be queued and dealt with by validation workers? If so we probably don't need an API unless the queue and workers need to be dealt with outside of AMO in which case this is a much bigger bug.
from addons-linter.
Yeah, this makes sense. I think the website might be a cool demo, but an HTTP API for validation wouldn't be world-facing.
This then becomes a bit of an add-ons rewrite question. If we want to do a bunch of micro-services that all talk HTTP to one another, writing a request-based API could be a thing, but even then the worker idea seems saner.
I could imagine an API that accepts a file and gives back a "validation request ID" one could poll for results with. But not a validation tied to the request/response cycle. Seems like an invitation for a timeout error if nothing else.
from addons-linter.
An aside re: "making sure we aren't too CLI":
Part of the intent to this bug was making sure we weren't too CLI-focused. But we started by outputting JSON before we even had pretty CLI output, so we are at least able to send our validation results off to places as-is.
from addons-linter.
We don't want to build an Express API after all; what we really want is the ability to interact with Celery and run this in a queue from Olympia.
I'll close this as I don't think it's actually needed anymore; we don't need a direct web interface to the validator.
from addons-linter.
Related Issues (20)
- Rename the artificial messages API / messages.json to i18nMessages.json
- Import Firefox 126 schema HOT 4
- manifest.json not found in .zip file
- Some tests fails on Windows
- Typo: `UNEXPECTED_GLOGAL_ARG` -> `UNEXPECTED_GLOBAL_ARG` HOT 1
- 6.28.0 deprecation warnings HOT 2
- Import Firefox 127 schema HOT 2
- --scan-file Produces Different Linter Results for a File Compared to When the Entire Add-on is Linted
- Consider removing the `MANIFEST_V3_FIREFOX_ANDROID_LIMITATIONS` rule HOT 5
- Warn about optional_permissions without optional_host_permissions / host_permissions
- Prevent the use of the enterprise flag HOT 2
- Introduce a --enterprise flag HOT 1
- Enterprise add-ons should be treated as self-hosted add-ons HOT 1
- An extra quotation mark at the end a sentence HOT 1
- Enterprise add-ons should not be able to define an `update_url` in the manifest HOT 1
- Import Firefox 128 schema HOT 1
- Import Firefox 129 schema HOT 1
- Create Github action to automatically import schemas from Firefox
- (Feature request) Add option to respect .gitignore when linting HOT 1
- Replace `cheerio` with one dependency (`parse5`)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addons-linter.