[mig agent] Windows support & MSI packaging (Bugzilla #1116003)

[mozilla]

[mig agent] Windows support & MSI packaging (Bugzilla #1116003)

[mvanotti]

Hi!
I was able to create the shortcut without problems, but I need a little bit more information about the WXS file (https://github.com/mozilla/mig/blob/master/conf/mig-agent-installer.wxs )

The guids are created randomly? Should I just create a new guid for any new element I'd like to add?
Why does the MainExecutable have a GUID as its id? Is it inteded to be the same forever? We could use something like MigAgentBinary as the id.

[jvehent]

I have limited understanding of WXS, but I think at least the product.Id and ProductUpgradeCode need to remain the same across releases. The rest can probably change.
But if you've got a better way to do this, feel free to change it.

[mvanotti]

I see that. But I'm talking about the Id of the File in the MainExecutable component, I need to refer to that from the ShortCut. It's ok, I can reuse that Id, but all the tutorials and examples I've seen use more detailed names, in this case, something like migAgentExe or migAgentBinary

[jvehent]

This one?

<File Name='mig-agent-$(var.ProductVersion).exe'
    Id='25ac5e4f-3f70-4e21-9389-7e5fcd6fde9d' />

If it's just a string and doesn't need to conform to a uuid format, just replace it with something sensible. MigAgentBinary sounds good.

[ameihm0912]

Issue no longer relevant as a number of Windows related changes have been made since