Add basic Seamonkey support to titlebar customization

[xabolcs]

Add basic Seamonkey support to titlebar customization

[whimboo]

Sounds fair enough. Code should be window type specific and we should take care of in #20 as well.

[xabolcs]

@tonymec noted again that NTT doesn't support SeaMonkey:

Recent updates on the NTT github master mention a "Customize Titlebar" dialog. Where is that dialog?
...

Phillip Chee's commit does the most of work with SeaMonkey's main window.

@tonymec (as SM and NTT user) (and also @whimboo) do You agree with
porting Philip's commit now (read: support browser window-types only)
and adding mail window-type support later (and the shared module enchancement)?

[tonymec]

On 22/10/12 22:37, Szabolcs Hubai wrote:

@tonymec https://github.com/tonymec noted again that NTT doesn't
support SeaMonkey:

Recent updates on the NTT github master mention a "Customize
Titlebar" dialog. Where is that dialog?
...

Phillip Chee's commit
http://hg.oxymoronical.com/extensions/NightlyTesterTools/rev/2c468e058583
does the most of work with SeaMonkey's main window.

@tonymec https://github.com/tonymec (as SM and NTT user) (and also
@whimboo https://github.com/whimboo) do You agree with
porting Philip's commit now (read: support browser window-types only)
and adding mail window-type support later (and the shared module
enchancement)?

IMHO, titlebar customization only in the browser is better than none.
IIRC, when NTT was “temporarily” unsupported and MR-Tech Toolkit was
working on all Toolkit applications (i.e., until Firefox 4, Gecko 2,
etc., not included), the MRTT title customization was only “good for the
browser” (e.g., even in the Mail window, the numbers of windows and tabs
that it could display were browser windows and browser tabs).

So my take on this question is: if you can do browser window title
customization (relatively) easily, by all means go ahead and do it, and
if mail window title customization will have to lag behind, well, so be it.

Best regards,

Tony.

MESKIMEN'S LAW
There's never time to do it right, but always time to do it over.

[xabolcs]

@whimboo, @tonymec
Are there a little chance to include this in milestone 3.4?

[whimboo]

If we get the remaining issue fixed which @tonymec is facing, I would be happy to include it.

[xabolcs]

@tonymec's issue is not just his issue as You can read in the related pull request (#104).
It's introduced with commit 3bb023c1c4da, shipped as NTT 3.0.

[xabolcs]

Opps, wrong number. 103 should be #104 👅

[whimboo]

If that's the case we can go ahead with pull #104 once I got the confirmation from tony.

[xabolcs]

That would be fine! :)

[tonymec]

@whimboo Which confirmation? Do you want me to test some advance build? Normally I pull the "mozilla" master on my local clone (I refrained recently because it had no titlebat customization and I had a "test xpi" which fixed that, well, except for that "known issue"), but I can test any xpi if I know exactly which one.

[xabolcs]

@tonymec: check #104! (specifically comment-10105675)

[whimboo]

@xabolcs thank you for the patch! Good to see that this feature has been landed now.

[xabolcs]

Edited description:

• this is a basic extension to NTT
• NTT overlays only the navigator window in Seamonkey, and this issue doesn't change that
• see the talk on mozillaZine about the full support of Seamonkey