Comments (1)
Hello @MaJerle,
thanks a lot for your suggestion about the sizeof()
operator! Appreciate your feedback very much.
PRINTF_NTOA_BUFFER_SIZE
is used as a (macro defined) module scoped constant here.
I would agree to use ARRAY_SIZE
or COUNTOF
macros if the buffer size is set by a magic number, is externally defined or depends on element initialization (buffer[] = { ... };
) etc.
But in this case here using a well defined constant (even named XXX_BUFFER_SIZE) for setting the buffer size and checking its length in different expressions is perfectly fine (and automotive safe).
Using 'ARRAY_SIZE' has the advantage that one can define a buffer with an arbitrary size and the bounds check always works, that's right - but IMHO not mandatory necessary here.
I don't see., why and how this should lead to a bug here, except one would change char buf[PRINTF_NTOA_BUFFER_SIZE]
to something like char buf[20]
or char buf[PRINTF_NTOA_BUFFER_SIZE - 10U]
- but that would be a serious violation (which coverity should find anyway).
Besides PRINTF_NTOA_BUFFER_SIZE
is used in _ntoa_format()
where buf
is unknown as buffer (it's just a pointer there).
from printf.
Related Issues (20)
- Use more appropriate types for base, precision and width HOT 4
- Avoid geneal-case division and modulus in _ntoa functions
- Undefined behavior on INT_MIN HOT 1
- Proper handling of denormals
- printf_("%.1e", 9.96) prints "10.0e+00", should print "1.0e+01"
- Printing +/-0 with "%g" doesn't fall back to decimal mode
- More cases of "%g" not falling back to decimal mode
- Support for FreeRTOS lxip specifier HOT 1
- Siginificant-digits-to-precision transition made invalid by rounding
- Floating point printing - how?
- Vfctprintf
- could you support %I64d %I64u like msvc done? HOT 1
- [notice] https://github.com/eyalroz/printf <-This repo is maintaining HOT 8
- Zero padding disabled when precision specified HOT 3
- this is incredible HOT 6
- WebAssembly HOT 2
- GCC flags for freestanding? HOT 2
- for declaration not compatible with C compilers HOT 1
- _vsnprintf reads past the format parameter value HOT 6
- I've created an Arduino Library from your source code HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from printf.