mpeg5/xevd

eXtra-fast Essential Video Decoder, MPEG-5 EVC (Essential Video Coding)

xevd's Issues

Thread safe implementation

I guess xevd might have some global variables written during operation.
It makes a race condition between instances if several instances are created in an application.
Someone need to check whether xevd has risk of thread safe or not.

supporting multiple parameter sets

Currently, xevd supports only one SPS and PPS.
According to standardization, multiple SPS and PPS should be supported.

Error in build process (dangling-pointer)

I was trying to build xevd in my linux - system
but During the build process, my system always sends this warnings and faild to "make"

/home/waganawa/문서/RA/xevd/src_main/xevdm.c: In function ‘xevd_apply_filter’:
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3204:34: error: storing the address of local variable ‘g_dra_control_effective’ in ‘*mctx.pps_dra_params’ [-Werror=dangling-pointer=]
3204 | mctx->pps_dra_params = (void )&(g_dra_control_effective.signalled_dra);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3187:21: note: ‘g_dra_control_effective’ declared here
3187 | DRA_CONTROL g_dra_control_effective;
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3187:21: note: ‘ctx’ declared here
/home/waganawa/문서/RA/xevd/src_main/xevdm.c: In function ‘xevd_decode’:
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3610:34: error: storing the address of local variable ‘dra_control_effective’ in ‘(XEVDM_CTX *)id.pps_dra_params’ [-Werror=dangling-pointer=]
3610 | mctx->pps_dra_params = &(dra_control_effective.signalled_dra);
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3593:17: note: ‘dra_control_effective’ declared here
3593 | DRA_CONTROL dra_control_effective;
| ^~~~~~~~~~~~~~~~~~~~~
/home/waganawa/문서/RA/xevd/src_main/xevdm.c:3593:17: note: ‘id’ declared here
cc1: all warnings being treated as errors

is there something I missed?

Warning in GCC 11, 12

    inlined from 'xevd_recon_tree' at xevdm.c:1778:9:
xevdm.c:1124:9: warning: 'xevdm_IBC_mc' accessing 98304 bytes in a region of size 32768 [-Wstringop-overflow=]
 1124 |         xevdm_IBC_mc(x, y, log2_cuw, log2_cuh, core->mv[0], ctx->pic, core->pred[0], mcore->tree_cons, ctx->sps.chroma_format_idc);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xevdm.c: In function 'xevd_recon_tree':
xevdm.c:1124:9: note: referencing argument 7 of type 'pel (*)[16384]' {aka 'short int (*)[16384]'}
In file included from xevdm_def.h:625,
                 from xevdm.c:38:
xevdm_mc.h:76:6: note: in a call to function 'xevdm_IBC_mc'
   76 | void xevdm_IBC_mc(int x, int y, int log2_cuw, int log2_cuh, s16 mv[MV_D], XEVD_PIC *ref_pic, pel pred[N_C][MAX_CU_DIM], TREE_CONS tree_cons, int chroma_format_idc);
      |      ^~~~~~~~~~~~

Possible incorrect results returned by xevd_config function for XEVD_CFG_GET_MAX_CODING_DELAY input parameter

I'm not sure but it seems to me that the xevd_config function call returns the incorrect value for the XEVD_CFG_GET_MAX_CODING_DELAY input parameter.

I mean the call like the following one:
xevd_config(id, XEVD_CFG_GET_MAX_CODING_DELAY, &max_coding_delay, &size);

Why do I think so?
It's because the function always returns the value of 0 even if the decoded stream was previously encoded with a value of bframes parameter other than zero.

While encoding the raw video stream I set XEVE_CDSC::param::bframes to be 15 (I did it just right before creating the encoder instance).
However, while decoding the previously encoded stream the value of XEVD_CFG_GET_MAX_CODING_DELAY received from SPS NALU was equal to 0.

I expect that the value of max encoding delay received by calling xevd_config(id, XEVD_CFG_GET_MAX_CODING_DELAY, &max_coding_delay, &size) will be the same, at least correlated to, as the value bframes set while encoding the stream.

Correct me If I'm wrong.

Problem with sps in xevd_config function

When function xevd_config(XEVD id, int cfg, void * buf, int * size) is used, xevd_app sample application and any other that is using xevd is crashing.
This happens because sometimes inside xevd_config sps from context is null.

xevd/src_main/xevdm.c

Line 3553 in 1385ab5

t0 = ctx->sps->picture_crop_left_offset + ctx->sps->picture_crop_right_offset;

Reproduction:

1. uncomment line:

   xevd/app/xevd_app.c

   Line 522 in 1385ab5

   //get_extra_config(id);

2. Run xevd_app with any video source.

Backtrace:

(gdb) bt
#0  xevd_config (id=0x7ffff7f83010, cfg=402, buf=0x7fffffffd978, size=0x7fffffffd990)
    at /home/user/git/xevd/src_main/xevdm.c:3553
#1  0x0000555555559b80 in get_extra_config (id=0x7ffff7f83010)
    at /home/user/git/xevd/app/xevd_app.c:202
#2  0x000055555555a9be in main (argc=5, argv=0x7fffffffdc98)
    at /home/user/git/xevd/app/xevd_app.c:522
(gdb) 

(gdb) p ctx
$1 = (XEVD_CTX *) 0x7ffff7f83010

(gdb) p ctx->sps
$2 = (XEVD_SPS *) 0x0

Problem building with -DARM=TRUE

Hello! i'm trying build with -DARM=TRUE with alpine linux via docker on an aarch64 host (mac book m3) but running into various build errors.

$ uname -a
Linux 00823b109f1f 6.6.16-linuxkit #1 SMP Fri Feb 16 11:54:02 UTC 2024 aarch64 Linux

$ mkdir build && cd build
$ cmake -DARM=TRUE ..
$ gcc --version
gcc (Alpine 13.2.1_git20231014) 13.2.1 20231014
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Some problems encountered:

/xevd/src_main/xevdm.c:3386:28: error: 'xevdm_itrans_map_tbl_neon' undeclared (first use in this function); did you mean 'xevdm_itrans_map_tbl'?
 3386 |     xevd_func_itrans     = xevdm_itrans_map_tbl_neon;

/xevd/src_main/neon/xevdm_itdq_neon.c:1401:14: error: array subscript 16 is above array bounds of 'int32x4_t[16]' [-Werror=array-bounds=]
 1401 |             t[16] = vzip2q_s32(v[0], v[1]);

/xevd/src_main/neon/xevdm_mc_neon.c: In function 'xevdm_bl_mc_l_n0_neon':
/xevd/src_main/neon/xevdm_mc_neon.c:827:57: error: 'tbl_bl_mc_l_coeff' undeclared (first use in this function); did you mean 'tbl_mc_l_coeff'?
  827 |     mc_filter_bilin_horz_neon(ref, s_ref, pred, s_pred, tbl_bl_mc_l_coeff[dx], w, h, min, max, MAC_ADD_N0, MAC_SFT_N0, 1);
      |                                                         ^~~~~~~~~~~~~~~~~
      |                                                         tbl_mc_l_coeff

Problem with bumping process starting...

[ 171] NALU --> B-slice (4971 bytes, poc=123, tid=4, [L0 122 120 ] [L1 124 128 ]
End of file
bumping process starting...

I don't know why the decoder stops working