VLAN parsing/diffing of "blobs" of config

[mpenning]

VLAN parsing/diffing of "blobs" of config

[mpenning]

The feature looks reasonably good for now. Please file a bug if you find a problem.

[mpenning]

Due to my schedule lately, it took a lot longer to respond, but please take a look sync_diff() in ciscoconfparse/master and let me know what you think. I have been tweaking this off and on for a while, and it seems to mostly behave the way I want (>80% of the time). For your use case, it looks good to me.

This is an example of the usage...

from ciscoconfparse import CiscoConfParse
#!!!!!!!!! Vlan test

BROKEN = """!
vlan 51
 state active
vlan 53
!""".splitlines()

WORKING = """!
vlan 51
 name SOME-VLAN
 state active
vlan 52
 name BLAH
 state active
!
""".splitlines()

linespec = r'vlan\s+\S+|name\s+\S+|state.+'
parse = CiscoConfParse(BROKEN)
diff = parse.sync_diff(WORKING, linespec, linespec)

When you run that, you'll get this in the diff variable...

['no vlan 53', 'vlan 51', ' name SOME-VLAN', 'vlan 52', ' name BLAH', ' state active']

Which is the config diff you need to sync those vlan configurations. Again, I'm not finished with this code, but I think it's good enough for your use case right now... frankly it's been that way for almost a week, but this fails in some of my corner cases and I was hoping to make one big commit that fixed everything.

Anyway, let me know whether this works for you.

[mpenning]

This feature is formally available in 1.2.11. Note that there is a bug in Python3, which breaks usage so for now sync_diff() requires Python2. I will file a bug in python.org tonight (US Time).

@CrackerJackMack, this might be useful for your config audits

[CrackerJackMack]

@mpenning nice!

[lingfish]

Hi, sorry for the delays.

I've been giving this a quick spin, and it seems mostly ok? The issues I think are potential difference in whitespace indentation etc (eg. one space from IOS, two from NXOS etc). If we then ignore whitespace, we kind of lose the "grouping" if you will of ^vlan [0-9]+ and ^ +name.

It almost needs to be a multiline, grouped diff, and not line by line.

[mpenning]

@lingfish,

Regarding whitespace, which version are you testing against, and what exactly failed? Please provide an explicit example. I just added explicit NXOS whitespace unit tests in 398da77 (to master, a few commits ahead of 1.2.14) and no unit tests are broken.

Regarding grouped diffs, I've started that, but I have a few more enhancements coming. It's still a bit dumb, but if you look at config_heirarchy(), you'll see that I'm already preparing to group diffs by oldest parent