Giter Site home page Giter Site logo

Images transition about pannellum HOT 5 CLOSED

mpetroff avatar mpetroff commented on August 25, 2024
Images transition

from pannellum.

Comments (5)

umbreak avatar umbreak commented on August 25, 2024

Right now, after some fixes you made, the images transition does not work. Even setting the value to null. It appears a black image when you try to select another hotspot.

As far as I saw, removing the line 1343 in pannellum.js (where init() function is called)it solves the issue.

But I think this init function is doing a lot of stuff which I guess is useful. I kept testing, and I see that after the renderer is reasigned (line 209), the image shown turns black. It looks like is something messed up with that new renderer instance returned (when changing the image).

from pannellum.

mpetroff avatar mpetroff commented on August 25, 2024

I am unable to reproduce this; the image transitions still work fine for me. Is it black just for the fade, or does it stay black? I'm guessing nothing is printed to the console. While I don't think it will make a difference in this case, set things to undefined instead of null as this is what the code compares against.

from pannellum.

umbreak avatar umbreak commented on August 25, 2024

If I don't put the option sceneFadeDuration, when I change the image, it shows a black image. The hotspots are there, and they're moving when I drag. But not the image.

I sent you a mail with a link with an example of my issue.

from pannellum.

mpetroff avatar mpetroff commented on August 25, 2024

I was able to track down the issue. With autoLoad specified in a tour, the autoLoad code was executed when each scene was loaded. This should never have happened, but it didn't affect anything before. A change I made caused this bug to manifest itself and break things; the extra call caused a second canvas to be created off-screen that displayed the image, while the on-screen canvas was blank. Now that I fixed it, things should work again.

from pannellum.

umbreak avatar umbreak commented on August 25, 2024

Yes now is solved. Thanks!

from pannellum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.