Giter Site home page Giter Site logo

Comments (5)

stax76 avatar stax76 commented on June 26, 2024 2

I could reproduce it and think I understand now what's wrong, I fix it in the next couple of days.

from mpv.net.

stax76 avatar stax76 commented on June 26, 2024 2

A new release fixing it is available.

from mpv.net.

stax76 avatar stax76 commented on June 26, 2024 1

In mpv.net v6 most CLI options were set after the initialization of the mpv core, in v7 this was changed to all CLI options being set before the initialization of the mpv core, I was told by a mpv developer that's the way to do it. It's probably this change causing the problem. I'll try to better understand it and fix it, but it will take time, as I'm currently taking a development break.

from mpv.net.

soredake avatar soredake commented on June 26, 2024

@Et0h can this be fixed on syncplay side by reading input-ipc-server value from mpv.conf and just using it?

from mpv.net.

Et0h avatar Et0h commented on June 26, 2024

@soredake It would be too complicated for Syncplay to do this. For example, there could be several different conf files and in those files there might be one than one input-ipc-server value, e.g. due to profiles. It is just way too hacky and unpredictable. It'd be far better to just tell the user to delete their input-ipc-server value.

@stax76 It's interesting that an mpv developer called for this behaviour as it results in different results to the main MPV.

Let's provide an easier to test example of osd-msg1.

In mpv-0.37.0-x86_64 if I put osd-msg1=Bob in mpv.conf but run with the argument osd-msg1=Alice, it will display Alice.
On the other hand, if I do the same in mpv.net v7 it will display Bob.

For most things this isn't a big deal as I can just override the value via the IPC connection once mpv.net has started, but if the input-ipc-server value is set then I don't have an IPC connection in the first place.

If this is a known issue then people can just be instructed to not set input-ipc-server in their mpv.net configuration if they want to use Syncplay, and instead to set it via Syncplay itself (a feature I'm working on).

As such, this probably doesn't need to be seen as a high priority issue, but is worth knowing about.

from mpv.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.