Doram missing

[mrantares]

Doram missing

[wjrosa]

I have found a commit with the Doram implementation. I have opened a PR with that here:
wjrosa#3
Unfortunately, I will not able to test soon. So if anyone can do it, let me know if that works and I will open the PR to this repo :).

[raiken-mf]

src/DB/DBManager.js already applied
src/DB/Jobs/HairIndexTable.js already applied
src/DB/Monsters/MonsterTable.js already applied
src/Network/PacketRegister.js already applied
src/Network/PacketVerManager.js already applied
src/Network/PacketVersions.js already applied
src/UI/Components/CharSelect2/CharSelect2.css already applied
src/UI/Components/CharSelect2/CharSelect2.html already applied

src/UI/Components/CharSelectV2/CharSelectV2.css already applied
src/UI/Components/CharSelectV2/CharSelectV2.html already applied

src/UI/Components/CharSelectV3/CharSelectV3.css already applied
src/UI/Components/CharSelectV3/CharSelectV3.html already applied

src/UI/Components/PincodeWindow/PincodeWindow.css already applied
src/UI/Components/PincodeWindow/PincodeWindow.html already applied
src/UI/Components/PincodeWindow/PincodeWindow.js already applied

src/Engine/CharEngine.js already applied (Except the packetver if at line 105, but should be covered, so no change required)
src/Engine/LoginEngine.js already applied (Except the packetver, no if on PR, no change required)
src/Network/PacketStructure.js already applied
Except line 10516, size is -1 instead of 12 in PR,
line 11385, fp.readBinaryString(24) instead of 26 in PR
line 11386 not present, maybe because of 24 instead of 26)
src/Renderer/Entity/EntityView.js already applied (Except line 208, added job parameter, not needed?)

src/DB/Effects/EffectTable.js adds stun wav

src/DB/Jobs/JobConst.js Lines already exist, just with prefix "DO_" and suffix "1"
src/DB/Jobs/JobNameTable.js Lines already exist, just with prefix "DO_" and suffix "1"

I'm willing to test it. Which client version should I pick?
The PR isn't working with packetver 20180530. The Packets aren't defined and the sprite on character select is blank.
[Warning]: clif_parse: Received unsupported packet (packet 0x8480 (0x8480), 17 bytes received), disconnecting session #7.

packetver 20170614
No chars displaying on char-select (But previously created)
[Error]: chr->parse_char: Received unknown packet 0x970 from ip '172.22.0.5'! Disconnecting!

[MrAntares]

Amazing find! Unfortunately I won't be able to test it either, since my server version is 2012-04-10 and I don't have the nerve and time to update to a version that supports Doram. Regardless of this, I am more than happy to pull any working implementation into my master :)

[raiken-mf]

The act and spr file for Doram job doesn't load.

[Thread] Can't get file (data/sprite/µµ¶÷Á·/¸öÅë/³²/summoner_³².spr)
onThreadError @ GameEngine.js:293
Receive @ Thread.js:98
GameEngine.js:293

[Thread] Can't get file (data/sprite/µµ¶÷Á·/¸Ó¸®Åë/³²/2_³².spr)
onThreadError @ GameEngine.js:293
Receive @ Thread.js:98
GameEngine.js:293

(also *.act)

But the files are present. Is there a new file type for spr or act that roBrowser can't handle yet?

Edit: I forgot to set up remote client...... I used your cache all the time.

[MrAntares]

Maybe we don't use the correct path in DB manager?

[MrAntares]

Doram sprite & skills are working on 2015.11 client.
Only the sprite actions need adjustment since they differ from the normal human ones.