Giter Site home page Giter Site logo

Regression on GEMM allocation about laser HOT 3 CLOSED

mratsim avatar mratsim commented on May 18, 2024
Regression on GEMM allocation

from laser.

Comments (3)

mratsim avatar mratsim commented on May 18, 2024

Commenting out extras bench like OpenBLAS and compiling with nim cpp -r -d:useSysAssert -d:useGcAssert --stacktrace:on -d:release -o:build/gemm_f32_omp benchmarks/gemm/gemm_bench_float32.nim

we get [SYSASSERT] dealloc: object header corrupted (e898f02)
or [SYSASSERT] result wrong pointer! (current master c4ac93d) depending on the commit we are on.

from laser.

mratsim avatar mratsim commented on May 18, 2024

It can be reproduced with full debug:

A matrix shape: (M: 1920, N: 1920)
B matrix shape: (M: 1920, N: 1920)
Output shape: (M: 1920, N: 1920)
Required number of operations: 14155.776 millions
Required bytes:                   29.491 MB
Arithmetic intensity:            480.000 FLOP/byte
Theoretical peak single-core:    224.000 GFLOP/s
Theoretical peak multi:         4032.000 GFLOP/s
Make sure to not bench Apple Accelerate or the default Linux BLAS.
15052863
3932223
15052863
3932223
15052863
3932223
15052863
3932223
Traceback (most recent call last)
gemm_bench_float32.nim(346) gemm_bench_float32
gemm_bench_float32.nim(181) benchLaserGEMM
gemm.nim(215)            gemm_strided
gemm_tiling.nim(341)     newTiles
alloc.nim(929)           alloc
alloc.nim(795)           rawAlloc
alloc.nim(596)           getBigChunk
alloc.nim(211)           removeChunkFromMatrix2
SIGSEGV: Illegal storage access. (Attempt to read from nil?

The crash is in the second allocShare at the start of the 6th benchmark iteration

from laser.

mratsim avatar mratsim commented on May 18, 2024

Fixed in #28, the newTiles proc wasn't getting mc, nc and kc from partitionMNK in the correct order

from laser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.