Giter Site home page Giter Site logo

Comments (3)

phlickey avatar phlickey commented on May 14, 2024

On further testing, offsetLeft and offsetTop probably aren't sufficient.

Would probably need to be something like:

let elementOffset;
  if (this.ref.current){
    let {x,y} = this.ref.getBoundingClientRect()
    elementOffset = { x, y }
  }else{
    elementOffset = {x: 0, y: 0}
  }

Is there a better place that this offset could be calculated and stored somewhere stateful? Does it make sense to add it to the resize observer?

from react-flow-chart.

mayansalama avatar mayansalama commented on May 14, 2024

This has been bugging me as well - would be great to get this sorted.

from react-flow-chart.

phlickey avatar phlickey commented on May 14, 2024

Looks like the offset is already being stored in state, and updated through the resize observer, just not being used when calculating the position property of the new node created on the onDrop event.

Made a PR that adds it in, since it seems pretty cut and dry and unlikely to affect anything else
#34

from react-flow-chart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.