Giter Site home page Giter Site logo

Comments (3)

MrOrz avatar MrOrz commented on May 14, 2024 1

We also need to access more data in inner component (<Port> in our case). In the end we decided to add extra properties to config prop.

Actually there was once a prop called nodeProps in config: https://github.com/MrBlenny/react-flow-chart/blob/master/src/types/config.ts#L9 . At that time the nodeProps was passed down to NodeInner and Node: 2dfa8ab . However, the latest API passes the whole config down to each component, thus codes relevant to nodeProps is removed in the code base. I guess this means that it is encouraged to put extra stuff in config...?

from react-flow-chart.

dmitrygalperin avatar dmitrygalperin commented on May 14, 2024

I started working on my PR for #54. You actually have access to the port data in Link.wrapper. You can pass down the port type to Link and then use it in generateCurvePath to figure out which direction to start in

from react-flow-chart.

fenech avatar fenech commented on May 14, 2024

@MrOrz in this case, I guess it would make sense to use config to specify the link type (e.g. "curved" or "angular") but I would still need to pass the sides of the ports at link.to and link.from. Are you suggesting that I add extra properties to config from inside Link.wrapper (and @MrBlenny can I interpret that your 👍 is approving that idea)?

Something like:

config = {
   ...config,
   portConfig: {
    to: "bottom",
    from: "top"
  }
}

from react-flow-chart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.