More complete status

[dbochicchio]

More complete status

[dbochicchio]

| but you agreed to my proposed change, right 🤔

you know, it looked good in theory, but then I discovered it won't work for my edge case. no problem, I'm not complaining at all. Thanks for the hard work ;)

[mrbungle64]

Hi @dbochicchio

the latest iteration of the lib has broken my code, since I was watching for MoppingSystemInfo to get the status, even when not mopping.

but you agreed to my proposed change, right 🤔
#80 (comment)

The idea behind it is to carry both water info (if present) and clean info (I'm calling it from cleanspeed as well and maybe the function name is not fitting anymore). What do you think?

It's ok for me. I will change it later today.

[mrbungle64]

@dbochicchio

Please check if this fits for your use case:

emitMoppingSystemReport() {
    const vacuumPowerAdjustmentOk = !this.bot.hasVacuumPowerAdjustment() || (this.bot.cleanSpeed !== null);
    const moppingSystemOk = !this.bot.hasMoppingSystem() || (this.bot.waterLevel !== null);
    if (vacuumPowerAdjustmentOk && moppingSystemOk) {
        let r = {
            'cleanStatus': this.bot.cleanReport
        };
        if (this.bot.hasVacuumPowerAdjustment() && (this.bot.cleanSpeed !== null)) {
            r['cleanInfo'] = {
                'level': this.bot.cleanSpeed
            }
        }
        if (this.bot.hasMoppingSystem() && (this.bot.waterLevel !== null)) {
            r['waterInfo'] = {
                'enabled': Boolean(Number(this.bot.waterboxInfo || 0)),
                'level': this.bot.waterLevel
            }
        }
        this.emit("MoppingSystemInfo", r);
    }
}

[mrbungle64]

@dbochicchio

I just made a commit based on my proposal from yesterday.