Installation fails while building a dep `onig_sys v69.5.0`

[mre]

Installation fails while building a dep `onig_sys v69.5.0`

[mre]

A reason not to upgrade (yet): we will probably need a few more releases until the API stabilizes. I don't expect a lot of work for "clients", but that should be mentioned.

Thanks for the heads-up. Will wait a bit and set a reminder to check back in a few weeks then. 👍
I can already tell that bat's builder offers a few very nice functions that are missing in prettyprint, like snip(). Nice work!

[pravic]

Now it works, thanks.

[sharkdp]

The llvm/clang dependency can be avoided by updating cargo-inspect and prettyprint to syntect 4.2.0 (see #56), which depends on an updated version of onig/onig_sys, that avoids the bindgen dependency (which in turn needs llvm/clang).

Alternatively, we could move cargo inspect from prettyprint to bat (see comment in prettyprint README: https://github.com/mre/prettyprint/), which already depends on syntect 4.2.0.

[mre]

@palash25 thanks for the report.

Merged #56 for now, which should fix it.
Can you test the following command and report back?

cargo install --git https://github.com/mre/cargo-inspect --branch master

@sharkdp thanks for the quick support here; I really appreciate it. In the long run we should move to bat. Is the builder pattern already implemented? I was not following closely lately.

[sharkdp]

Yes: https://docs.rs/bat/0.15.4/bat/struct.PrettyPrinter.html

Unfortunately, I was not able to make it 100% compatible with prettyprint (I definitely tried where possible), but I hope it should be easy to migrate.

[sharkdp]

A reason not to upgrade (yet): we will probably need a few more releases until the API stabilizes. I don't expect a lot of work for "clients", but that should be mentioned.

[palash25]

@mre I had already installed llvm on my machine before reading your comment but I still tried cargo install --git https://github.com/mre/cargo-inspect --branch master and it works fine

very cool tool by the way, thanks for building it

[mre]

Nice! 0.10.2 released on crates.io. 🎉

[pravic]

0.10.2 still fails:

Updating cargo-inspect
    Updating crates.io index
  Downloaded cargo-inspect v0.10.2
...
error: failed to run custom build command for `onig_sys v69.5.0`

Caused by:
  process didn't exit successfully: `c:\windows\temp\cargo-installZPmVMM\release\build\onig_sys-4152209514bd3ee8\build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Unable to find libclang: "couldn\'t find any valid shared libraries matching: [\'clang.dll\', \'libclang.dll\'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', d:\usr\local\rust\cargo\registry\src\github.com-1ecc6299db9ec823\bindgen-0.53.3\src/lib.rs:1956:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

warning: build failed, waiting for other jobs to finish...
error: failed to compile `cargo-inspect v0.10.2`, intermediate artifacts can be found at ```

[mre]

Aaah, I know what's going on. While syntect uses the latest version of onig now, we were still using prettyprint 0.7.2 with an old dependency. Ran a cargo upgrade now and checked with cargo tree that bindgen was indeed absent. Pushed to master now and created a new tag (0.10.3).
The reason why I didn't notice that was that I had libclang set up for another project on my machine.

@pravic, can you try to cargo install again?

[mre]

Thanks for the feedback and sorry for the inconvenience. 👍