Giter Site home page Giter Site logo

Comments (18)

mre avatar mre commented on May 24, 2024 2

Was wondering whether we should bundle ffmpeg with the app in order to avoid such scenarios. 🤔

from timelapse.

ItsThompson avatar ItsThompson commented on May 24, 2024

Make sure that you have ffmpeg installed (e.g. run brew install ffmpeg)

from timelapse.

ItsThompson avatar ItsThompson commented on May 24, 2024

Is there anyway you can check if the computer has ffmpeg already installed and if there isn't then download it?

from timelapse.

cmangla avatar cmangla commented on May 24, 2024

This user got a notification about ffmpeg only after "stop recording". Maybe we should warn users at startup time, just after the final print statement below:

def check_dependencies(self) -> None:
try:
subprocess.run(['ffmpeg'], check=True,
capture_output=True, timeout=10.0)
except subprocess.CalledProcessError:
print("ffmpeg command was found")
pass # ffmpeg is found, but returns non-zero exit as expected
# This is a quick and dirty check; it leaves some spurious output
# for the user to puzzle over.
except OSError:
print(not_found_msg)

from timelapse.

mre avatar mre commented on May 24, 2024

oh yeah. That print(not_found_msg) should be a notify, I guess. Wanna whip up a PR?

from timelapse.

mre avatar mre commented on May 24, 2024

Is there anyway you can check if the computer has ffmpeg already installed and if there isn't then download it?

Yeah that would be possible. Not sure if it's a bit too invasive, though. Hm...

from timelapse.

cmangla avatar cmangla commented on May 24, 2024

oh yeah. That print(not_found_msg) should be a notify, I guess. Wanna whip up a PR?

I remember some discussion in which we said that not_found_msg was too long for a notify, am I right?

from timelapse.

mre avatar mre commented on May 24, 2024

Heh, yeah maybe a shorter message would help.

from timelapse.

dnywh avatar dnywh commented on May 24, 2024

Hi, new user here.

I'm getting the same error as @anandvip. I did the brew install ffmpeg before first-use. I also tried brew reinstall ffmpeg. No dice.

Running Catalina 10.15.4 (19E287).

from timelapse.

mre avatar mre commented on May 24, 2024

Welcome @dannyalright,
that's odd. What does ffmpeg --version give you on the commandline?

from timelapse.

cmangla avatar cmangla commented on May 24, 2024

@mre Perhaps we need to add shell=True to the line below in Encoder:

completed = subprocess.run(
command, capture_output=True, check=True)

Just a guess.

from timelapse.

dnywh avatar dnywh commented on May 24, 2024

Thanks, @mre!

ffmpeg version 4.2.2 is what I get in response to ffmpeg --version.

Here's the full response:

ffmpeg version 4.2.2 Copyright (c) 2000-2019 the FFmpeg developers
  built with Apple clang version 11.0.3 (clang-1103.0.32.59)
  configuration: --prefix=/usr/local/Cellar/ffmpeg/4.2.2_3 --enable-shared --enable-pthreads --enable-version3 --enable-avresample --cc=clang --host-cflags=-fno-stack-check --host-ldflags= --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libbluray --enable-libmp3lame --enable-libopus --enable-librubberband --enable-libsnappy --enable-libsrt --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxvid --enable-lzma --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librtmp --enable-libspeex --enable-libsoxr --enable-videotoolbox --disable-libjack --disable-indev=jack
  libavutil      56. 31.100 / 56. 31.100
  libavcodec     58. 54.100 / 58. 54.100
  libavformat    58. 29.100 / 58. 29.100
  libavdevice    58.  8.100 / 58.  8.100
  libavfilter     7. 57.100 /  7. 57.100
  libavresample   4.  0.  0 /  4.  0.  0
  libswscale      5.  5.100 /  5.  5.100
  libswresample   3.  5.100 /  3.  5.100
  libpostproc    55.  5.100 / 55.  5.100
Unrecognized option '-version'.
Error splitting the argument list: Option not found

from timelapse.

anandvip avatar anandvip commented on May 24, 2024

Make sure that you have ffmpeg installed (e.g. run brew install ffmpeg)

I did, I can see the screen shots in recent files, some odd 1600 screen shots. how ever during installation ffmpeg did instruct to change the path for some of the files, which one? I don't know...

from timelapse.

anandvip avatar anandvip commented on May 24, 2024

Was wondering whether we should bundle ffmpeg with the app in order to avoid such scenarios. 🤔

Yes, that would be great!

from timelapse.

digidestination avatar digidestination commented on May 24, 2024

I have the same issue on macOS Monterey 12.4 any help would be appreciated.

ffmpeg 5.0.1_3 is already installed and up-to-date.
Python 3.10.0

from timelapse.

mre avatar mre commented on May 24, 2024

What does

which ffmpeg

say?

What does this print?

python3 -c 'import shutil; print(shutil.which("ffmpeg"))'

from timelapse.

mre avatar mre commented on May 24, 2024

Was wondering whether we should bundle ffmpeg with the app in order to avoid such scenarios. 🤔
Yes, that would be great!

With the new M1 chips we'd end up bundling two versions of ffmpeg I guess: one for Intel Macs and one for arm64. :/ So I don't think we want to bundle ffmpeg after all...

from timelapse.

digidestination avatar digidestination commented on May 24, 2024

Hello and thank you for your reply,
Both commands say this:
/usr/local/bin/ffmpeg

from timelapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.