Bed Size from Configuration.h are not loaded to Printer Settings

[mriscoc]

Bed Size from Configuration.h are not loaded to Printer Settings

[mriscoc]

You can use a g-code configuration file with custom g-codes to set the physical dimensions: https://github.com/mriscoc/Ender3V2S1/wiki/Custom-C-gcodes

[oldo439]

OK. I just wanted to know where the problem is. Whether it's a bug in the firmware or it just doesn't load from configuration.h during compilation. I change the firmware quite often and every time I have to manually adjust the Dimensions in the Menu. G-code is usable, but not practical.
I assume the problem will be in the original Marlin code.

[oldo439]

I found something in file: mriscoc\Marlin_Ender3v2\Marlin\src\lcd\e3v2\proui\dwin_defines.h

#if ProUI
  #undef X_BED_SIZE
  #undef Y_BED_SIZE
  #undef X_MIN_POS
  #undef Y_MIN_POS
  #undef X_MAX_POS
  #undef Y_MAX_POS
  #undef Z_MAX_POS
  #undef NOZZLE_PARK_POINT
  #if HAS_MESH
    #undef GRID_MAX_POINTS_X
    #undef GRID_MAX_POINTS_Y
    #undef GRID_MAX_POINTS
  #endif
  #if HAS_BED_PROBE
    #undef PROBING_MARGIN
    #undef Z_PROBE_FEEDRATE_SLOW
  #endif
  #undef INVERT_E0_DIR

  #define X_BED_SIZE (float)HMI_data.x_bed_size
  #define Y_BED_SIZE (float)HMI_data.y_bed_size
  #define X_MIN_POS  (float)HMI_data.x_min_pos
  #define Y_MIN_POS  (float)HMI_data.y_min_pos
  #define X_MAX_POS  (float)HMI_data.x_max_pos
  #define Y_MAX_POS  (float)HMI_data.y_max_pos
  #define Z_MAX_POS  (float)HMI_data.z_max_pos
  #define NOZZLE_PARK_POINT {(float)HMI_data.Park_point.x, (float)HMI_data.Park_point.y, (float)HMI_data.Park_point.z}

But I don't understand why is for ProUI this:
#undef X_BED_SIZE
and then
#define X_BED_SIZE (float) HMI_data.x_bed_size

I don't know, what is HMI_data

I used before:
#define DWIN_CREALITY_LCD_ENHANCED // Enhanced UI
and now is there:
#define DWIN_LCD_PROUI // MRiscoC Enable ProUI

[mriscoc]

If you disable the ProUI feature you will be able to set your physical dimensions using the configuration files but also you will lose the ability to edit the values from the menu and g-code.

[oldo439]

I understand. But those default numbers must be entered somewhere in the source code. Can we find them? I would change it there if it can't be changed in Configuration.h
Even so, I adjust the settings with each new firmware. So I'll add the bed dimensions to the change list.

[mriscoc]

In the file dwin.cpp
Adds to DWIN_SetDataDefaults():

void DWIN_SetDataDefaults() {
  TERN_(DEBUG_DWIN, SERIAL_ECHOLNPGM("DWIN_SetDataDefaults"));
  DWIN_SetColorDefaults();
  DWINUI::SetColors(HMI_data.Text_Color, HMI_data.Background_Color, HMI_data.StatusBg_Color);
  TERN_(HAS_HOTEND,             HMI_data.HotendPidT = PREHEAT_1_TEMP_HOTEND);
  TERN_(HAS_HEATED_BED,         HMI_data.BedPidT    = PREHEAT_1_TEMP_BED);
  TERN_(HAS_HOTEND,             HMI_data.PidCycles  = 5);
  #ifdef PREVENT_COLD_EXTRUSION
    HMI_data.ExtMinT = EXTRUDE_MINTEMP;
    ApplyExtMinT();
  #endif
  #if HAS_HEATED_BED && ENABLED(PREHEAT_BEFORE_LEVELING)
    HMI_data.BedLevT = PREHEAT_1_TEMP_BED;
  #endif
  TERN_(ProUI, ProEx.SetDefaults());
  #if ENABLED(BAUD_RATE_GCODE)
    HMI_data.Baud115K = false;
    SetBaud250K();
  #endif
  HMI_data.x_bed_size = 230;
  HMI_data.y_bed_size = 227;
  HMI_data.x_max_pos  = 245;
  HMI_data.y_max_pos  = 230;
  HMI_data.z_max_pos  = 220;
  ProEx.ApplyPhySet();
}

[oldo439]

Great, that's exactly what I needed. Thank you very much. I'll test it tomorrow.

[oldo439]

It works. Thank you once again.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.