Giter Site home page Giter Site logo

Comments (10)

naktinis avatar naktinis commented on July 24, 2024

Not sure what your opinion is about extending intermediateTo (which this issue was about). For some reason we were only discussing alongTrackDistanceTo.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

My apologies, I clicked the wrong issue, twice. The name intermediateTo (and intermediatePointTo) and the comments in the JS code implied that only factor values 0..1 were suitable. But the JS code puts no restriction on the factor value, I'd be happy to do that in the Python version.

from pygeodesy.

naktinis avatar naktinis commented on July 24, 2024

Completely agree about naming.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

Good. There are 3 spherical intermediate... methods and the fraction restriction is being removed for all, just to be consistent.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

All done in PyGeodesy-17.4.28 plus some other modifications.

from pygeodesy.

naktinis avatar naktinis commented on July 24, 2024

Are there any tests for fractions outside 0..1? I think h computation does not work for such values. Otherwise it looks ok.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

No tests, but I'll check with the original author. Also, I'll add a height keyword. If not None, it will replace the fractional default.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

A keyword argument height=None has been added to all intermediate...To and several other methods to override the computed, default or fractional height value in PyGeodesy-17.5.01+. There are other updates as well, including 2 simplistic tests for spherical and ellipsoidal intermediateTo methods with fraction values outside 0..1.

from pygeodesy.

mrJean1 avatar mrJean1 commented on July 24, 2024

@naktinis, has this been resolved to your satisfaction?

from pygeodesy.

naktinis avatar naktinis commented on July 24, 2024

Seems to work as expected. Thank you.

from pygeodesy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.