feature request: Include source code location for each node

[mrleebo]

feature request: Include source code location for each node

[MrLeebo]

It sounds intriguing. prisma-ast is built with chevrotain.js, but I'll admit I don't really know that much about building syntax trees and mostly just stumbled my way through this project. It produces an AST because they were simpler to implement than CSTs.

I believe chevrotain does support location info for tokens, so it would be possible to surface that info.

What I'd like to do is have a better API for querying the document, but until now I never really had a good idea for the sorts of use cases an API like that would need to serve. I'm open to your suggestions on what kinds of features a prisma-ast Query interface would be most helpful to provide.

[maxh]

I believe chevrotain does support location info for tokens, so it would be possible to surface that info

Makes sense! Let me look into this a little bit and circle back. I haven't thought too deeply beyond the idea of mirroring ESLint and RuboCop developer experience.

What I'd like to do is have a better API for querying the document, but until now I never really had a good idea for the sorts of use cases an API like that would need to serve.

The visitor pattern implemented in the linter works well for traversal:

https://github.com/loop-payments/prisma-lint/blob/7cc13d728ac850ce675b1aeac4e6d13a614f83d6/src/lint-prisma-source-code.ts#L41-L61

But maybe there is a better approach, or other use cases for a query API.

[MrLeebo]

@maxh I've created a PR with the option to enable node location tracking. It's only sort of partially implemented, to fit in with the way the schema is currently shaped, but perhaps it will be enough for your use cases.

Can you try it out and see if it works for your usage?

Location tracking is disabled by default, since there is an impact on parsing performance, but you can turn it on by adding a configuration option to your package.json file.

{
  "prisma-ast": {
    "parser": {
      "nodeLocationTracking": "full"
    }
  }
}

After that, "location" statistics will appear on certain parts of your schema output from getSchema(). The available statistics will appear as such:

{
    type: 'generator',
    name: 'client',
    assignments: [...],
    location: {
      startLine: 7,
      startColumn: 1,
      startOffset: 79,
      endLine: 7,
      endColumn: 16,
      endOffset: 94
    }
  }

Hopefully that will be sufficient for your linter.

[maxh]

Looks promising! I'm testing it out here:

loop-payments/prisma-lint#84

But running into problems with types; not sure if your side or mine:

There are types at '/home/runner/work/prisma-lint/prisma-lint/node_modules/@mrleebo/prisma-ast/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@mrleebo/prisma-ast' library may need to update its package.json or typings.

https://github.com/loop-payments/prisma-lint/actions/runs/5502248068/jobs/10026376231?pr=84

[MrLeebo]

@maxh Please try again.

I had added a "exports" section to the package.json, but I guess it broke the TypeScript typings so I rolled it back.

[maxh]

Ok, it is looking good:

loop-payments/prisma-lint#84

In the test scenario, I have it printing:

model Users {
^^^^^^^^^^^

It seems that model nodes have location nodes but field nodes do not. Is that expected? I think ideally if there is a field-level violation we can underline that field specifically.

Given that the variance in position and context for model names and field names is pretty standardized (models are top-level nodes, fields are nested within them), I'm second-guessing whether it makes to mirror ESLint and RuboCop for the CLI rendered output of the linter.

But there are other use cases for these locations -- for example an LSP implementation for highlighting errors inside an editor.

[MrLeebo]

Fixed the presence of location data for field and attribute node types.

[maxh]

Looking ready to go! One small thing -- I wasn't able to import the CstNodeLocation type when annotating a function:

https://github.com/loop-payments/prisma-lint/pull/84/files#r1266591956

Otherwise LGTM. I have another library in the pipeline this will be perfect for too. Thanks!!

[MrLeebo]

Added CstNodeLocation to the export, but it is just a pass-thru from chevrotain, so you can also get it from there.

import type { CstNodeLocation } from '@mrleebo/prisma-ast';
// is the same as
import type { CstNodeLocation } from 'chevrotain';