Giter Site home page Giter Site logo

Results box hides content about pesticide HOT 4 CLOSED

mrmrs avatar mrmrs commented on August 22, 2024
Results box hides content

from pesticide.

Comments (4)

paulmolluzzo avatar paulmolluzzo commented on August 22, 2024

I'm open to a PR for sure! It's not my repo, but FWIW 👍.

I think the idea of a toggle (with like an X in the upper corner of the div-thingy) sounds nice, but making it draggable is cool too. Another idea I had was to make it switch to the top when you scrolled down within X% of the the bottom of the page, but I'm concerned that it'll be jerky and that introducing an event listener on the scroll event is going to cause weird performance issues. There's no telling what is happening on the page to begin with, so if you inject some RAF-type scenario it could get crazy.

That brings up something else to consider: Keeping this in vanilla JS and not introducing dependencies is probably the best bet to avoiding unforeseen issues. Again, there's no telling what is on the page when you inject this JS.

@mrmrs what do you think? You tweeted you had some ideas...?

from pesticide.

bradleyflood avatar bradleyflood commented on August 22, 2024

+1

from pesticide.

paulmolluzzo avatar paulmolluzzo commented on August 22, 2024

@winkerVSbecks @bradleyflood Check the update I just pushed. Always off, hold control to see the banner. I think it's a pretty clean solution.

from pesticide.

winkerVSbecks avatar winkerVSbecks commented on August 22, 2024

awesome 👍

from pesticide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.