Segfault when use msgpack as session serialize handler at PHP7

[msgpack]

Segfault when use msgpack as session serialize handler at PHP7

[Sean-Der]

Hey @ryukoui

I am rebuilding PHP master right now, had an older build for extension development. Unfortunately I was not able to hit this issue.

But lets try to debug a couple other things! Are you able to reproduce this with the CLI SAPI? php your-script.php , or is this an issue that only shows up with apache2handler (don't currently have a setup using that)

thanks!

[ryukoui]

Thanks for your reply, @Sean-Der

I did some test. Just as you said looks like this issue is only shows up with apache2handler.

I ran the code below with CLI, and apache2.4

ini_set('session.serialize_handler', 'msgpack');
session_start();

echo php_sapi_name();

$_SESSION['cnt'] = isset($_SESSION['cnt']) ? $_SESSION['cnt'] + 1 : 0;
echo $_SESSION['cnt'];

CLI finished with no error.
apache2.4 still give me segfault.

Sorry for my bad english by the way.
Hope this help.

[Sean-Der]

Your english is as good as people who ONLY speak it, so no worries :)

Does session related stuff work at all in apache2handler? It looked like Nginx + php-fpm was just a permissions error (looks like you removed it from your comment so you fixed it?)

There is a bug here, but I don't think it is with msgpack-php. Maybe the session API has changed, but this might not to be triaged/elevated to php-src.

[laruence]

what is the problem here?

[laruence]

nevermind, @Sean-Der, maybe you could make a PR against PHP to fix that

[Sean-Der]

@laruence that sounds be fun! Will reproduce it tonight, and hopefully submit a useful PR

[laruence]

@Sean-Der, cool, thanks :)

[Sean-Der]

Hey @ryukoui

Would you mind trying the php7 branch again, 7a5bdb1 is the fix I pushed

@laruence totally false alarm on my end :/ just a case of the tests not hitting the case where sessions are decoded after an initialize pulls a saved session. I will see what I can do about getting a test around this!

thanks

[ryukoui]

Hey @Sean-Der

7a5bdb1 fixed the problem perfectly!
For real you saved my weekend :)

I really appraciate you guys helping.

[Sean-Der]

That is great to hear :)

Thanks for using msgpack-php, and catching bugs before for other people!