Comments (5)
I've just merged both your PRs. Thanks for your contribution! I just realized I forgot to add your link to the readme. I'll just do that now.
from pokesprite.
- Upon further investigation, it seems like genesect-standard.png shouldn't exist as -standard is an alias of genesect.png for Gen8, so I'll remove the shiny/genesect-standard.png sprite unless otherwise stated.
- (ignore this line, github keeps converting the 3. to a 2. if I don't include this)
- I've noticed there's an existing Arceus Unknown entry, but it is an alias of Arceus Normal. If the sprites are wanted, can I replace the alias with the sprites above or should I use a different suffix for this form?
from pokesprite.
Good catch! Yeah, I'm actually a little bit confused by the Genesect sprite now because originally the "standard" icon was, I think, actually different. But I don't remember exactly how it worked back then.
If you check the gen7x
dir, you'll see that genesect
has no drive visible at all, which seems to be what the games had, and then separately there's a "standard" sprite that has a different color than any of the four drives. I don't know if that one's actually used in-game or if that's a non-standard sprite (in any case it's not listed as a non-standard sprite).
I'm guessing that in gen8
they changed this, and now the Genesect sprite is never shown in the "no drive" style, and so the "standard" sprite needs to be deleted, seen as how it's already listed in the data file as alias.
Also yes, feel free to make a copy of Appletun, it seems I just totally forgot about that.
As for Arceus, please feel free to make a PR for that too, but maybe you can make it a separate one since I'm looking at the sprites now and I think there may be some small changes I need to make to others. Like my Bug Arceus has red eyes and it shouldn't, so I should just double check them all.
Regarding the project, maybe it'd be good to add that link and then also the link to the project page besides it?
from pokesprite.
Yeah, it didn't notice the missing drive either until my second comment, haha. I wonder why they changed it.
I've made a PR for the Appletun and Genesect changes #112 . I'll make a separate Arceus PR when I get the time tomorrow or the day after.
That sounds like a good idea!
from pokesprite.
Awesome. I'll have a look at it when I've got some time this weekend.
from pokesprite.
Related Issues (20)
- Pokémon BDSP - New Icons HOT 7
- Custom female Wobbuffet sprites. HOT 1
- Pokémon LA - New Graphics HOT 5
- Pokemon PLA Sprites for Spreadsheet HOT 2
- Missing Galarian Sprites HOT 3
- Shiny Tentacruel sprite colors HOT 3
- Pixel Sprites for Hisui Balls dumped from HOME HOT 1
- [REQUEST] Origin Marks under Misc HOT 4
- shiny/decidueye-hisui same color as decidueye-hisui HOT 2
- Add Sprite for Uncloaked Burmy
- Add Generation 1/2 Icon Sprites
- 2x Single wrong pixel gen8 HOT 1
- Twinkling Star Ribbon is still missing HOT 1
- [Request] PoGo? HOT 3
- Yakkun zukan sprites HOT 2
- Add sprites from Pokemon Scarlet and Violet HOT 17
- Major updates to Pokésprite HOT 10
- Can you add Pokemon sprite that are in the world (meaning seen there 4 faces)
- Addition of Pokemon Legends Arceus sprites
- Exception Error After Building and Randomizing Pokemon HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokesprite.