Genesect Gen8 sprite inconsistency / missing Appletun-Gmax / contribution question(s)

[PTGigi]

Genesect Gen8 sprite inconsistency / missing Appletun-Gmax / contribution question(s)

[msikma]

I've just merged both your PRs. Thanks for your contribution! I just realized I forgot to add your link to the readme. I'll just do that now.

[PTGigi]

1. Upon further investigation, it seems like genesect-standard.png shouldn't exist as -standard is an alias of genesect.png for Gen8, so I'll remove the shiny/genesect-standard.png sprite unless otherwise stated.
2. (ignore this line, github keeps converting the 3. to a 2. if I don't include this)
3. I've noticed there's an existing Arceus Unknown entry, but it is an alias of Arceus Normal. If the sprites are wanted, can I replace the alias with the sprites above or should I use a different suffix for this form?

[msikma]

Good catch! Yeah, I'm actually a little bit confused by the Genesect sprite now because originally the "standard" icon was, I think, actually different. But I don't remember exactly how it worked back then.

If you check the gen7x dir, you'll see that genesect has no drive visible at all, which seems to be what the games had, and then separately there's a "standard" sprite that has a different color than any of the four drives. I don't know if that one's actually used in-game or if that's a non-standard sprite (in any case it's not listed as a non-standard sprite).

I'm guessing that in gen8 they changed this, and now the Genesect sprite is never shown in the "no drive" style, and so the "standard" sprite needs to be deleted, seen as how it's already listed in the data file as alias.

Also yes, feel free to make a copy of Appletun, it seems I just totally forgot about that.

As for Arceus, please feel free to make a PR for that too, but maybe you can make it a separate one since I'm looking at the sprites now and I think there may be some small changes I need to make to others. Like my Bug Arceus has red eyes and it shouldn't, so I should just double check them all.

Regarding the project, maybe it'd be good to add that link and then also the link to the project page besides it?

[PTGigi]

Yeah, it didn't notice the missing drive either until my second comment, haha. I wonder why they changed it.

I've made a PR for the Appletun and Genesect changes #112 . I'll make a separate Arceus PR when I get the time tomorrow or the day after.

That sounds like a good idea!

[msikma]

Awesome. I'll have a look at it when I've got some time this weekend.