Comments (5)
Yes, it's quite possible to update in the distribution. I have several thoughts that I'd happily accept PRs for (I'm on holiday now and will be quite busy for a while after returning):
- Add a section to DEVELOP.md with things to do before cutting a release. On such item on the list would be: update PSL.
- Remove the PSL from the distro entirely, since we already added code that loads and keeps the PSL updated. Make sure docs are up-to-date.
from mail-dmarc.
I think I'd probably lean toward (2) because otherwise the PSL is only as recent as the dist. When the dist's frequency of release goes down, the shipped PSL is more and more out of date.
That said, I would be happy to write a Dist::Zilla plugin to check that the PSL is up to date or something, if you prefer to go that way.
from mail-dmarc.
I lean towards #2 as well. Automatically keeping the PSL up to date at run time seems the most reasonable default. We just need to make sure that our update code creates the sharedir if missing (due to removal of PSL from the dist.)
from mail-dmarc.
That should be no problem. We just throw a zero-byte file in ./share and call it a day. ;)
from mail-dmarc.
I haven't looked into it far enough, but our auto-update solution for the PSL isn't as robust enough to skip including it in the distro:
% sudo /usr/local/bin/dmarc_update_public_suffix_list
HTTP Request for Public Suffix List file failed with error 599 (Could not connect to 'publicsuffix.org:443': Non-recoverable failure in name resolution
)
% fetch https://publicsuffix.org/list/effective_tld_names.dat
effective_tld_names.dat 100% of 172 kB 583 kBps 00m00s
% sudo mv effective_tld_names.dat /usr/local/lib/perl5/site_perl/auto/share/dist/Mail-DMARC/public_suffix_list
from mail-dmarc.
Related Issues (20)
- 'responsebeacon.com not in DNS'
- Can't locate Email/Sender/Transport/Test.pm in @INC
- defined-or used
- no more verbose output with dmarc_send_reports --verbose
- Use of uninitialized value $value
- dmarc_send_reports causing protocol synchronization errors on receiving MTA
- Invalid XML in generated reports HOT 3
- error sending report: Can't locate object method "code" via package "timeout " HOT 1
- Would like to have a way to specify port and ssl actions for imap
- t/04.PurePerl.t started to fail
- Reports with delivery issues aren't removed HOT 1
- Possible issue with ARC-signed emails HOT 2
- spamassassin 4 fails to make dmarc repots HOT 2
- Is Net::SSLeay used ? HOT 1
- use MIME::Entity and MIME::Parser from MIME::Tools instead of Email::MIME HOT 3
- Disposition is 'reject' but should be 'none' for subdomain HOT 3
- Unable to view backends in ./t/travis/backends HOT 4
- Several issues in file search functions
- TLS is not properly enforced for IMAP connections HOT 2
- Unsafe use of eval in Report::Store
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mail-dmarc.