Giter Site home page Giter Site logo

Comments (5)

msimerson avatar msimerson commented on June 28, 2024

Yes, it's quite possible to update in the distribution. I have several thoughts that I'd happily accept PRs for (I'm on holiday now and will be quite busy for a while after returning):

  1. Add a section to DEVELOP.md with things to do before cutting a release. On such item on the list would be: update PSL.
  2. Remove the PSL from the distro entirely, since we already added code that loads and keeps the PSL updated. Make sure docs are up-to-date.

from mail-dmarc.

rjbs avatar rjbs commented on June 28, 2024

I think I'd probably lean toward (2) because otherwise the PSL is only as recent as the dist. When the dist's frequency of release goes down, the shipped PSL is more and more out of date.

That said, I would be happy to write a Dist::Zilla plugin to check that the PSL is up to date or something, if you prefer to go that way.

from mail-dmarc.

msimerson avatar msimerson commented on June 28, 2024

I lean towards #2 as well. Automatically keeping the PSL up to date at run time seems the most reasonable default. We just need to make sure that our update code creates the sharedir if missing (due to removal of PSL from the dist.)

from mail-dmarc.

rjbs avatar rjbs commented on June 28, 2024

That should be no problem. We just throw a zero-byte file in ./share and call it a day. ;)

from mail-dmarc.

msimerson avatar msimerson commented on June 28, 2024

I haven't looked into it far enough, but our auto-update solution for the PSL isn't as robust enough to skip including it in the distro:

% sudo /usr/local/bin/dmarc_update_public_suffix_list
HTTP Request for Public Suffix List file failed with error 599 (Could not connect to 'publicsuffix.org:443': Non-recoverable failure in name resolution
)
% fetch https://publicsuffix.org/list/effective_tld_names.dat
effective_tld_names.dat                       100% of  172 kB  583 kBps 00m00s
% sudo mv effective_tld_names.dat /usr/local/lib/perl5/site_perl/auto/share/dist/Mail-DMARC/public_suffix_list

from mail-dmarc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.