Comments (5)
Would RENDERER_NO_ACCESS_KEY=true
environment variable suffice?
from electron-render-service.
Why not just set RENDERER_ACCESS_KEY=
?
from electron-render-service.
That would need accessKey=
to give the blank key as query param, might as well set some simple access key then.
I could change the default startup behaviour of not starting when no keys are defined, but that would make it unauthenticated by default.
from electron-render-service.
But since RENDERER_ACCESS_KEY
is set, one could reason that RENDERER_ACCESS_KEY=
would imply that unauthenticated use is intended... When the environment var is missing, you could say the service isn't configured properly.
from electron-render-service.
Since there is no encryption tied to authentication it creates a false impression of security. So if you either use the service through docker or standalone you will have to enable encryption somehow. I usually use an nginx reverse proxy for that. If I have that in place I might as well add basic auth since it can be handled in the same directive. I'd drop the auth token altogether.
BTW: Thank you very much for the awesome repo. I tried all the available solutions but yours works well and fast. I changed some dependencies to slim down the image a bit though.
from electron-render-service.
Related Issues (20)
- Refactor waitForText to use HTML body (allows to wait for non-visual text) HOT 3
- Docker Swarm mode misc. points HOT 2
- Feature request: Debian packages HOT 4
- Styles not being rendered correctly HOT 3
- Empty PDFs when writing to file using Node.js... HOT 1
- insecure dependency
- How to disable certificate check? HOT 2
- Version 10 of node.js has been released
- Private Websites HOT 1
- Unable to install on Debian 9 HOT 1
- An in-range update of supertest is breaking the build 🚨 HOT 2
- Is this repo still maintained? HOT 7
- An in-range update of eslint is breaking the build 🚨 HOT 2
- An in-range update of electron is breaking the build 🚨 HOT 1
- An in-range update of electron is breaking the build 🚨 HOT 6
- An in-range update of eslint-plugin-jest is breaking the build 🚨 HOT 6
- An in-range update of eslint is breaking the build 🚨 HOT 3
- An in-range update of prettier is breaking the build 🚨 HOT 1
- An in-range update of eslint-plugin-import is breaking the build 🚨 HOT 3
- How to use the service with a wikimedia page that needs authentication? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-render-service.