Giter Site home page Giter Site logo

make auth optional about electron-render-service HOT 5 OPEN

msokk avatar msokk commented on May 30, 2024
make auth optional

from electron-render-service.

Comments (5)

msokk avatar msokk commented on May 30, 2024

Would RENDERER_NO_ACCESS_KEY=true environment variable suffice?

from electron-render-service.

Reggino avatar Reggino commented on May 30, 2024

Why not just set RENDERER_ACCESS_KEY=?

from electron-render-service.

msokk avatar msokk commented on May 30, 2024

That would need accessKey= to give the blank key as query param, might as well set some simple access key then.
I could change the default startup behaviour of not starting when no keys are defined, but that would make it unauthenticated by default.

from electron-render-service.

Reggino avatar Reggino commented on May 30, 2024

But since RENDERER_ACCESS_KEY is set, one could reason that RENDERER_ACCESS_KEY= would imply that unauthenticated use is intended... When the environment var is missing, you could say the service isn't configured properly.

from electron-render-service.

burningTyger avatar burningTyger commented on May 30, 2024

Since there is no encryption tied to authentication it creates a false impression of security. So if you either use the service through docker or standalone you will have to enable encryption somehow. I usually use an nginx reverse proxy for that. If I have that in place I might as well add basic auth since it can be handled in the same directive. I'd drop the auth token altogether.

BTW: Thank you very much for the awesome repo. I tried all the available solutions but yours works well and fast. I changed some dependencies to slim down the image a bit though.

from electron-render-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.