Giter Site home page Giter Site logo

Comments (4)

dashed avatar dashed commented on April 28, 2024 2

@kettanaito seems to work 👍 thanks for looking into this! 😄

from msw.

kettanaito avatar kettanaito commented on April 28, 2024 1

A very good call. To be honest, the entire mask matching could be improved.

Previously, it needed to have some weird stringification to evaluate the expressions on the Service Worker side. Now SW-client communicates over the message channel, and thus the routes matching is delegated to the library module.

I think I can get rid of stringification and treating RegExps as they are.

P.S. Stringification is also used to store the mocking route as the key in this.routes of MSW class.

from msw.

kettanaito avatar kettanaito commented on April 28, 2024

I will update the functionality in the next patch release so it will use matchPath (similar to one in react-router) and remove any stringification of route masks. It will, however, remove the support for wildcard * in the routes, I would need to add that later.

I've tested the latest changes with your use case and it works okay as "http://localhost:3000/cats" doesn't transform into RegExp.

from msw.

kettanaito avatar kettanaito commented on April 28, 2024

Published 0.2.2. The issue should be resolved now. Mocking both http://localhost:3000/cats and even http://localhost:*/cats works as expected.

Could you please verify that it works with the latest version?

from msw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.