Comments (8)
Alright. I found a workaround:
async function startServer() {
if (!navigator.serviceWorker.controller) {
const registrations = await navigator.serviceWorker.getRegistrations()
await Promise.all(registrations.map(r => r.unregister()))
}
await composeMocks(...handlers).start('/mockServiceWorker.js')
}
The key here is that if navigator.serviceWorker.controller
returns null
that means that either:
- The service worker hasn't been installed yet
- The installed service worker will not be used for requests until the next reload
So the solution is to get all existing service workers and unregister them before registering the new one.
I think this would be worthwhile including by default or making opt-in.
(this helped: https://stackoverflow.com/questions/35628243/how-to-prevent-hard-reloads-from-bypassing-the-service-worker)
from msw.
Found more relevant info: https://developers.google.com/web/fundamentals/primers/service-workers/lifecycle#shift-reload
Looks like this is spec. Need to find a workaround. This behavior will be really confusing for users of the app. Yes, I know msw isn't intended for production use, my use case is education so I realize that this may be an edge case msw doesn't want to handle. Though I'm pretty sure this will be confusing for developers using msw during development as well, so it's probably something worth handling.
from msw.
Works perfectly. Thank you so much!
from msw.
Thanks for reporting this, @kentcdodds. Sounds like a rather strange behavior, when you expect the service worker to be responding with mocks.
Would it be sufficient if we gathered all the registrations and unregister them within the start()
method of MSW? Before calling the navigator.serviceWorker.register()
method?
from msw.
I wonder what would happen for apps that use another service worker 🤔
from msw.
I believe this issue should be solved with #99. I've added an integration test that asserts hard reload behavior, as much as it can be asserted:
I've also verified it locally with the proposed changes, and the worker continues to handle requests after hard reload. Please expect this to be fixed once that pull request lands. Thank you for patience.
Internally, I didn't go with collecting all registrations and unregistering them. I believe this action would also unregister other Service Workers associated with the client. Instead, I ensure that
mockServiceWorker.js
unregisters itself on window unload.
from msw.
That's wonderful news! Thank you so much for this 💯
from msw.
Released in 0.13.0
.
This release comes with a change to mockServiceWorker.js
, so please make sure to:
$ npm install msw@latest
$ npx msw init <PUBLIC_DIR>
Hard reloading a page should no longer result into Service Worker being unable to handle requests. Could you please update and let me know how it behaves?
You may also need to unregister the currently running Service Worker manually for updates to propagate properly. Please do so if you notice unexpected behavior after updating. Thanks.
from msw.
Related Issues (20)
- Add delay before each request HOT 3
- Mock a request that contains both query and path parameters
- TypeError: confirm is not a function HOT 7
- Failing to intercept an Axios request: Node 20.11 + Vitest 1.3.1 + MSW 2.2.1
- v2.2.2 does not intercept request in browser mode (CORS error) but v1.3.1 does HOT 3
- Infering the `boundary` callback arguments HOT 7
- support custom fetch option HOT 7
- support selecting interceptors HOT 1
- Set-Cookie responses containing commas are not handled correctly HOT 1
- HttpResponse.json() throwing TypeError: Right-hand side of 'instanceof' is not an object. HOT 1
- Request with FormData body makes Jest hang forever HOT 6
- TypeError: Right-hand side of 'instanceof' is not an object HOT 4
- Cannot read properties of undefined (reading 'url') HOT 5
- Mocked data getting empty string HOT 8
- "InvalidStateError: The object is in invalid state" when mocking rest api
- Unable to use msw/node for testing solid-js due to `resolve.conditions` set to `browser` HOT 5
- drop CommonJS support HOT 2
- quiet: true should supress RESPONSE LISTENER logs HOT 4
- Narrowing the response body type in `HttpResponse.json` HOT 16
- Error: No known conditions for "./browser" specifier in "msw" package HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msw.