Comments (1)
Thanks for the detailed ticket!
I think option 1 makes sense. "There are no tags" and "there are no tags that match the pattern" aren't all that different, and we can extend --strict
to preserve the current error.
Regarding potential breakage:
- Since this only applies before you have a version tag, the scope is pretty small.
- If you handle the current error, then you'd probably set a fallback version as well.
- If you prefer a different fallback version than 0.0.0, then you already have to check if Dunamai gives you 0.0.0 so you can use something else instead, since we use 0.0.0 in several other cases.
- If you're worried about cases where CI doesn't have the full history and only fetches a subset of tags (possibly not including any version-like tags), then you should be using
--strict
.
from dunamai.
Related Issues (20)
- Could not properly parse with Version.parse HOT 9
- Possibly misleading vcs check message for git HOT 1
- Style is overwritten which causes validation of format regardless if user passed parameter HOT 15
- 1.16.0: pytest needs `setuptools` HOT 9
- dunamai.Version.from_git() fails if 'v' prefix not set HOT 4
- sdist is missing tests HOT 1
- Wrong version being reported HOT 9
- Bump fails for lazy clone (GitLab CI/CD) with `tag-branch = "master"` HOT 2
- dunamai 1.18.0 silently does not produce version with `--strict` in CI HOT 2
- Git version detection fails if `log.excludeDecoration = refs/tags` set in git config HOT 2
- Support getting versions from VCS at a specified directory HOT 2
- Visual Studio Code Workspace Settings file is missing ending `}` HOT 1
- calver versioning HOT 1
- Remove python dependency upper bound HOT 1
- `test__version__from_fossil` fails without home HOT 6
- bump behavior different in command line and python API HOT 4
- "RuntimeError: Unable to detect version control system" HOT 3
- Add option for detecting only changed files as dirty HOT 1
- Inconsistent distance for non-matching tags HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dunamai.