Comments (8)
One thing that makes the transition easier is that it can be done piecewise instead of globally, migrating one detector at a time away from StepPointMC.
from offline.
Adding a comment from Dave that was on a different thread - one obvious need is for a specialized class for steps in VDs.
from offline.
Thanks for accepting #379 PR.
I agree that the object combines hit and step information, but they are connected by the spacial info,
so it may not be so bad, but probably could be optimized.
Regarding it usefulness, now that the post momentum is there, it would be more correct/efficient to restore the particle
state in the multistage jobs from the post step info, as that step had been made already, instead of repeating it in some
sense (likely with a different outcome).
Regarding CrvSteps and similar use cases, care needs to be taken to check what happened in the post step phase,
to make sure the momentum is not e.g. zero and compare the velocity prediction with what is in the post step.
Krzysztof
from offline.
I would like to create a 'DetectorStep' class to summarize StepPointMCs for passive materials (IPA, target foils, etc). This would avoid downstream users having to add multiple StepPointMC objects to get physically meaningful results, and further insulates us from G4 details. This will eliminate StepPointMCs from the dts and further downstream output. They will still be used in resampling; perhaps a dedicated class there makes sense to.
from offline.
from offline.
from offline.
I like the name PasssiveMaterialStep.
I believe the plan is to produce StepPointMCs as before but to collect them into PasssiveMaterialStep objects at the same time as other DetectorStep objects are made. is that right?
If so, I recommend we go ahead.
from offline.
from offline.
Related Issues (20)
- GammaConvGenerator_module removed HOT 1
- Understand how to use, or not use, MessageFacility HOT 1
- Mu2e KinKal exceptions
- Scrub code base for literals 1695 and 1694 HOT 1
- Improve trigger Validation fcl HOT 1
- Revisit bug-fix IO Rule from PR 1156
- GenId::CeEndpoint vs ProcessCode::CeMinusEndpoint HOT 2
- As built locations in the Mu2e Hall
- root include path
- Where needed update the geometry to reflect as-built dimensions and locations
- g4 testing invokes reconstruction, bringing in database dependency HOT 5
- Add syntax to force CI to rebuild
- Offline split vs trig qualifier
- Rationalize types of constexpr definitions in CRVId.hh
- Some volumes break GEANT visualization HOT 1
- PrescaleEvent_module.cc prescaling algorithm
- no neutron in PDGCode enum-to-string
- Do we need to invent the concepts of a SpillId and MICycleId HOT 1
- regression in MT running for photonNuclear and gamma processes
- artdaq-core-mu2e/Data/EventHeader.hh
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from offline.