Giter Site home page Giter Site logo

Phasing out StepPointMC about offline HOT 8 OPEN

mu2e avatar mu2e commented on August 14, 2024
Phasing out StepPointMC

from offline.

Comments (8)

gaponenko avatar gaponenko commented on August 14, 2024

One thing that makes the transition easier is that it can be done piecewise instead of globally, migrating one detector at a time away from StepPointMC.

from offline.

kutschke avatar kutschke commented on August 14, 2024

Adding a comment from Dave that was on a different thread - one obvious need is for a specialized class for steps in VDs.

from offline.

resnegfk avatar resnegfk commented on August 14, 2024

Thanks for accepting #379 PR.

I agree that the object combines hit and step information, but they are connected by the spacial info,
so it may not be so bad, but probably could be optimized.

Regarding it usefulness, now that the post momentum is there, it would be more correct/efficient to restore the particle
state in the multistage jobs from the post step info, as that step had been made already, instead of repeating it in some
sense (likely with a different outcome).

Regarding CrvSteps and similar use cases, care needs to be taken to check what happened in the post step phase,
to make sure the momentum is not e.g. zero and compare the velocity prediction with what is in the post step.

Krzysztof

from offline.

brownd1978 avatar brownd1978 commented on August 14, 2024

I would like to create a 'DetectorStep' class to summarize StepPointMCs for passive materials (IPA, target foils, etc). This would avoid downstream users having to add multiple StepPointMC objects to get physically meaningful results, and further insulates us from G4 details. This will eliminate StepPointMCs from the dts and further downstream output. They will still be used in resampling; perhaps a dedicated class there makes sense to.

from offline.

gaponenko avatar gaponenko commented on August 14, 2024

from offline.

brownd1978 avatar brownd1978 commented on August 14, 2024

from offline.

kutschke avatar kutschke commented on August 14, 2024

I like the name PasssiveMaterialStep.

I believe the plan is to produce StepPointMCs as before but to collect them into PasssiveMaterialStep objects at the same time as other DetectorStep objects are made. is that right?

If so, I recommend we go ahead.

from offline.

brownd1978 avatar brownd1978 commented on August 14, 2024

from offline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.