Giter Site home page Giter Site logo

Comments (7)

xsdg avatar xsdg commented on August 17, 2024

@psmgeelen Is this something you'd like to work on? No worries if not. If so, let me know how much guidance would be helpful.

from mkchromecast.

psmgeelen avatar psmgeelen commented on August 17, 2024

@xsdg Yes! I would be. In terms of support, I would like to point out that I don't own a Mac, even though by the look of this, it doesn't seem that I really need one. Let me review properly this weekend and get back to you with a PR. What was the formatting again so I can connect my PR to the issue?

from mkchromecast.

xsdg avatar xsdg commented on August 17, 2024

Sounds good. I would suggest writing a new unit test that replicates this issue (see https://github.com/muammar/mkchromecast/blob/master/tests/test_instantiate.py ), and then making sure that your fix causes that unit test to start passing.

As for connecting things, you can mention an issue with #<issue number>. As for the actual integrations, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

from mkchromecast.

psmgeelen avatar psmgeelen commented on August 17, 2024

@xsdg I hope this is what you needed :)

from mkchromecast.

xsdg avatar xsdg commented on August 17, 2024

@muammar Could you confirm whether this bug is fixed?

from mkchromecast.

psmgeelen avatar psmgeelen commented on August 17, 2024

@xsdg Let me know if you have something else for me to fix ;)

from mkchromecast.

muammar avatar muammar commented on August 17, 2024

@muammar Could you confirm whether this bug is fixed?

It's fixed. I wanted to find the problem with the Sonos list not being populated, but got caught up with some stuff at work. Thanks for the follow up.

from mkchromecast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.