Comments (7)
@psmgeelen Is this something you'd like to work on? No worries if not. If so, let me know how much guidance would be helpful.
from mkchromecast.
@xsdg Yes! I would be. In terms of support, I would like to point out that I don't own a Mac, even though by the look of this, it doesn't seem that I really need one. Let me review properly this weekend and get back to you with a PR. What was the formatting again so I can connect my PR to the issue?
from mkchromecast.
Sounds good. I would suggest writing a new unit test that replicates this issue (see https://github.com/muammar/mkchromecast/blob/master/tests/test_instantiate.py ), and then making sure that your fix causes that unit test to start passing.
As for connecting things, you can mention an issue with #<issue number>
. As for the actual integrations, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
from mkchromecast.
@xsdg I hope this is what you needed :)
from mkchromecast.
@muammar Could you confirm whether this bug is fixed?
from mkchromecast.
@xsdg Let me know if you have something else for me to fix ;)
from mkchromecast.
@muammar Could you confirm whether this bug is fixed?
It's fixed. I wanted to find the problem with the Sonos list not being populated, but got caught up with some stuff at work. Thanks for the follow up.
from mkchromecast.
Related Issues (20)
- Deprecate youtube-dl for yt-dlp HOT 2
- Add encapsulation, reduce code duplication, and simplify cascading logic
- Does not play any audio on google speakers HOT 1
- sys tray disappears after searching for devices
- TypeError: Descriptors cannot not be created directly. HOT 2
- Using --video crashes the app HOT 2
- archlinux mkchromecast-git package targets unstable `master` branch HOT 5
- Error with start HOT 2
- Support for playlists
- Restore ability to use updated settings without restarting mkchromecast HOT 1
- How is it possible to transmit the volume, pause and resume via command line?
- `-n` fails to find Chromecast when TV is powered off
- Crash when I try to connect to a pair of Sonos One SL HOT 1
- Installing mkchromecast with brew HOT 1
- Issues with Tray Application: ModuleNotFoundError: No module named 'imp' HOT 5
- Unable to detect Sonos One speaker HOT 5
- Re-enable Sonos support in mkchromecast HOT 1
- Cant find Chromecast [Arch Linux]
- Glitch/bug on Mac Sonoma 14.5 (Macbook Air M2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mkchromecast.