Comments (4)
Both this issue and #9826 should be fixed by #10272.
The problem of this issue and #9826 is not that we're not providing a commonjs export. It's that we were declaring in the charts that we have a commonjs export while in reality it didn't work. It didn't work because there is no commonjs version of d3. (And we didn't build a workaround for that limitation yet as we want to spend our time building features first and take this opportunity to probe the community to see how big of a problem it would be to just not build that workaround ever)
Since module resolution amongst bundlers and custom setups these days is basically the wild west, some of them get totally confused. #10272 removes that faulty export so that modern enough bundlers don't get confused. I believe we can close these issues until the community makes a convincing case for us to add a non-broken commonjs version. i.e. Where being on a non-standard setup is justified. While there will be commonjs around for a very long time, the ratio commonjs/ESM will only decrease going forward.
(cc @alexfauquette Would it make sense to create a specific label for issues related to the charts ESM setup? It'd make it easier for me to keep tabs on them)
from mui-x.
Created charts: ESM
for it 👍
from mui-x.
Looks like I fixed it with https://www.npmjs.com/package/@originjs/vite-plugin-commonjs.
Let me know if I should close it, I guess that other people could have the same issue so maybe something can be done from the library side.
from mui-x.
So related to #9826.
from mui-x.
Related Issues (20)
- [data grid] No buttons on DataGridPro server-side pagination demo HOT 4
- [charts] ChartsLegendPropsBase type is broken HOT 1
- [data grid] Multi-sorting discoverability issues
- [charts] Is there a way to customize the popup when hovering the MUIX PieChart sections? HOT 3
- [data grid] baseCheckbox slot also overrides Column Chooser HOT 7
- [docs] How to mock license for testing HOT 2
- [data grid] How to enable 'linkOperator' in MUI Data Grid - Multi filters HOT 1
- [pickers][DatePicker] DatePicker with different locale also changes the input value HOT 11
- [charts] Tooltip - Custom Content HOT 4
- [charts] LinePlot does not allow to use scaleType 'points' HOT 11
- [pickers] Remove clear button in tab sequence HOT 1
- [charts] Chart Padding HOT 3
- [data grid] setting `apiRef.current.rootElementRef` HOT 4
- [data grid] Pinned column separators being clipped
- [pickers] DatePicker type input error HOT 2
- [data grid] Id for ColumnMenuIconButton on datagrid HOT 3
- [data grid] selecting cells by pressing keyboard arrows does not trigger onCellSelectionModelChange HOT 5
- [data grid] How to use `renderCell` for `defaultGroupColumn` when server-side loading HOT 4
- [pickers] `DateTimeRangePicker` throws error with `format` prop in MUI X Pro v7.11.0 HOT 1
- [data grid] Is `valueOptions` required to be set on `singleSelect` column types? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mui-x.