Giter Site home page Giter Site logo

Comments (7)

LukasTy avatar LukasTy commented on June 24, 2024 1

@marcel925 Thank you for creating this issue.
I've looked into it, sorry it took a bit longer because there was some more exploration of the root cause for the problems. 🙈
The idea would be to provide a custom day slot component, where the day is wrapped in a Tooltip component.
The problem is that the PickersDay component expects the onBlur and onFocus to receive the date as a second argument:

onBlur={(event) => onBlur(event, day)}

The issue is that the Tooltip component only forwards the event to the event handler:
https://github.com/mui/material-ui/blob/9b620c4918939ed9083883d2ce4c46e6b21b5214/packages/mui-material/src/Tooltip/Tooltip.js#L566

I'll look into proposing a fix on the mui-material side in order to support this behavior.

from mui-x.

LukasTy avatar LukasTy commented on June 24, 2024 1

@flaviendelangle I've bumped the @mui/material peerDep.
WDYT, would it make sense to add a documentation example for this case or we can close the issue as is? 🤔

from mui-x.

flaviendelangle avatar flaviendelangle commented on June 24, 2024 1

We could have a new example here

from mui-x.

LukasTy avatar LukasTy commented on June 24, 2024 1

We could have a new example here

I've added the issue to the grooming board.
We can add the example after the MUI Core bump is merged. 👌

from mui-x.

flaviendelangle avatar flaviendelangle commented on June 24, 2024 1

By the way, the pickers doc structure starts the be quite confusing if we end up with pure customization example on the DateCalendar page while most of them are on the "Visual customization" pages.
I do not have a clear proposal on how to improve it, but I think it's a problem to keep in mind while adding new examples.

from mui-x.

LukasTy avatar LukasTy commented on June 24, 2024

@marcel925 Just letting you know that the demo I listed in my previous comment works without the need for a hacky solution if the @mui/material package version is at least 5.15.13 (released today).
This is the updated demo.

WDYT @mui/explore @flaviendelangle would it make sense to bump the peerDep of @mui/material for this specific version?
I'm not sure it is warranted, because it targets a specific example (albeit one that could even become a documentation example) and there is a way ("hacky") to achieve the wanted behavior with older version... 🤷 🤔

from mui-x.

flaviendelangle avatar flaviendelangle commented on June 24, 2024

AFAIK nothing prevents the user to bump its minimal version of @mui/material
With that being said, I'm not against taking #12105 (which should merged before stable by the way :/ ) and use 5.15.13 on it

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.