Giter Site home page Giter Site logo

Comments (6)

michelengelen avatar michelengelen commented on May 28, 2024

Hey @theobrasseurbentley
thanks for opening an issue for this.
I am not sure if we can support an improvement on this at the moment.
One way would be to render the editing component inside of a popper that anchors on the top-left corner of the cell.
Let me give this a shot.

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

OK, so I did play around with this a bit and it is not possible with the current version. We would need a ref for the Popper to know where to render. We could actually do this when we would pass the cellRef into the GridRenderEditCellParams like this:

diff --git a/packages/x-data-grid/src/components/cell/GridCell.tsx b/packages/x-data-grid/src/components/cell/GridCell.tsx
index 81a23061e..fb1cf8e9b 100644
--- a/packages/x-data-grid/src/components/cell/GridCell.tsx
+++ b/packages/x-data-grid/src/components/cell/GridCell.tsx
@@ -429,6 +429,7 @@ const GridCell = React.forwardRef<HTMLDivElement, GridCellProps>((props, ref) =>
       row: updatedRow,
       formattedValue,
       ...editCellStateRest,
+      ref: cellRef,
     };

     children = column.renderEditCell(params);

that way we would also be able to provide some more flexibility in rendering edit cells.
I am not sure if this might have some performance implications.

Thoughts @cherniavskii or @romgrk ?

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

@theobrasseurbentley ... the best way would probably be to assign a minWidth to the cols that have the date or dateTime type.

const columns: GridColDef[] = [
  // ...
  {
    field: 'createdAt',
    headerName: 'Created at',
    type: 'date',
    minWidth: 180,
    editable: true,
  },
  // ...
];

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

Hey @theobrasseurbentley ... I did find a solution with Popper that works: Example

Let me know what you think! 👍🏼

from mui-x.

theobrasseurbentley avatar theobrasseurbentley commented on May 28, 2024

Thank you @michelengelen !
I think these solutions have merit.
Going with the min width for now.

from mui-x.

github-actions avatar github-actions commented on May 28, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@theobrasseurbentley: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.