Giter Site home page Giter Site logo

Comments (8)

cherniavskii avatar cherniavskii commented on May 28, 2024 2

the question still stands though: should we add something like this as a recipe?

It seems to be a quite niche use case, I would wait for upvotes on this first.

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

Hey @sanlee13
Is the edit mode triggering the cell/row edit mode?
Or is it a custom state inside the master detail content?

To accomplish this you would need to pass a custom cell renderer to the toggle column and find a way to pass the edit state from your master detail to that toggle renderer.

Could you maybe provide us with a minimal reproduction demo in codesandbox or stackblitz? That would help a lot!

from mui-x.

sanlee13 avatar sanlee13 commented on May 28, 2024

Hey @michelengelen,
So, when I expand the row, I have button that toggles a custom state that resides in the context data store. When I click the edit, I want to disable the row toggle (expand/collapse).

Here is a sandbox I made: https://codesandbox.io/p/sandbox/quirky-ptolemy-hdlrzd?file=%2Fsrc%2FDemo.js%3A25%2C5

EDIT: Keep an eye on the console

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

Hey @sanlee13
Is this what you are trying to achieve?

DEMO

This is making use of the row model and the apiRef.

from mui-x.

sanlee13 avatar sanlee13 commented on May 28, 2024

Hey @michelengelen,
Yes, this is precisely what I'm aiming to achieve. Your approach is fascinating and something I wouldn't have considered on my own.

Thank you very much for your assistance.

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

Great that this solution works for you.

@cherniavskii should we maybe add this as a recipe to the docs?

from mui-x.

cherniavskii avatar cherniavskii commented on May 28, 2024

@michelengelen I don't love the idea of mutating row data to reflect the editing state TBH.
Forking GridDetailPanelToggleCell isn't perfect either.
I forked your demo and made 2 changes:

  • used React context for editing state
  • reused GridDetailPanelToggleCell component

https://codesandbox.io/p/sandbox/silent-frog-tqp59h

What do you think?

from mui-x.

michelengelen avatar michelengelen commented on May 28, 2024

Yes, that's a great solution.
I was thinking of using state or context at first as well, but honestly don't know why i diverted from that. Probably because using state would potentialy lead to unnecessary rerenders 🤷🏼

Thanks for providing that solution ... the question still stands though: should we add something like this as a recipe?

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.