Giter Site home page Giter Site logo

Comments (4)

michelengelen avatar michelengelen commented on August 25, 2024 1

Hey @lukaskoeller and thanks for raising this.
It seems as if the footer has no background color defined by default.

using this makes it work:

sx={{
  blockSize: 629,
  [`& .${gridClasses.footerContainer}`]: {
    backgroundColor: 'white',
  },
}}

from mui-x.

michelengelen avatar michelengelen commented on August 25, 2024

Noted: this is just a workaround and we should look into fixing this.
cc @cherniavskii

from mui-x.

lukaskoeller avatar lukaskoeller commented on August 25, 2024

Hey @lukaskoeller and thanks for raising this. It seems as if the footer has no background color defined by default.

using this makes it work:

sx={{
  blockSize: 629,
  [`& .${gridClasses.footerContainer}`]: {
    backgroundColor: 'white',
  },
}}

Thanks @michelengelen for the workaround. Though, I noticed that for both the v6 and the v7 reproduction, the last row in the table is then always hidden behind the table footer. I would expect this one to be visible as any other table row. Isn't it something that needs to be fixed too?

from mui-x.

lukaskoeller avatar lukaskoeller commented on August 25, 2024

@michelengelen I tried to get a more similar reproduction to our production application. I noticed that it still looks off, even with your workaround applied:

Actual

There's a bottom border line and the last visible row is cut of

Expected

  • No bottom border line
  • All 7 items, not only 6 are visible
  • The last row (in this case the 6th) is not cut off vertically

Reproduction: https://stackblitz.com/edit/react-z2fhwt-71kzsu?file=Demo.tsx

Screenshot 2024-07-18 at 08 31 34

from mui-x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.