Comments (9)
Hey there, @stefanbuck
This is the place I am using this action
https://github.com/mujo-code/source/blob/master/.github/workflows/push.yml#L32
and here is the configuration of puppeteer
https://github.com/mujo-code/source/blob/master/packages/extension/src/e2e.test.js#L19
The only thing that jumps out to me is the different passing of args. I pass it in a with block. Let me know if that working and I can update the documentation around this.
from puppeteer-headful.
Right after opening this issue I spotted this as well. Thanks for confirming this and I'll let you know if this works.
from puppeteer-headful.
This works, but only if I use test
to issue a npm test
command. In my case I want to use npm run e2e
so set args
to run e2e
. This seems to be cut off on the whitespace.
from puppeteer-headful.
yup! left a comment over on the other repo.
OctoLinker/OctoLinker#662 (review)
I think your use case is more common so I am open to changing the way the command is executed.
from puppeteer-headful.
I just pushed a commit with args: '"run e2e"'
which should work, but it looks super weird 😆
from puppeteer-headful.
What about decoupling this from npm
so you can pass every command like npm test
, npm run whatever
or even run.sh
?
from puppeteer-headful.
Seems like that run failed. I am also up for that. I am not sure who all is using it. I know if we switch to just a running a sh script that will bust any existing. that being said I do thing that is probably the right direction.
from puppeteer-headful.
Here we go #9
from puppeteer-headful.
@stefanbuck I merged it thanks again, I think you can run it off master. Let me know if you need a release setup to try.
from puppeteer-headful.
Related Issues (19)
- Support new with params HOT 5
- Unable to view output from command HOT 4
- Cannot run Puppeteer in sandbox mode? HOT 3
- Setup a simple test repo.
- actions/npm@master in readme isn't available HOT 1
- It's possible to see the launched chrome in docker? HOT 3
- Add FFMPEG
- Marketplace shows 12.3.1 as latest version HOT 1
- Add a license HOT 2
- Unable to launch browser HOT 1
- Downloading Chrome in Docker container causes mismatch issues.
- The browser is crashing after when loading the extension
- Upgrade node to v18.7.0 HOT 2
- Commands that are chained with && are not fully executed HOT 1
- Error: net::ERR_BLOCKED_BY_CLIENT at chrome-extension:// HOT 2
- Cannot find npm cache on GitHub actions HOT 2
- How to run it with docker-compose HOT 4
- Does it work with the puppeteer `v22.12.0` ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppeteer-headful.