Giter Site home page Giter Site logo

Comments (1)

mkrautz avatar mkrautz commented on May 18, 2024

This is basically implemented now, with a few changes.

  • First time a user connects to a server with a self-signed certificate, they're presented with a dialog that allows them to:
    • Ignore it (and connect anyway)
    • Trust it (store its SHA1 digest in the DB)
    • Cancel (do nothing)
  • If a certificate has been "trusted" by a user, it is (as noted above) stored in the DB. Next time the user connects to the server (and is told that the OS could not verify the authenticity of the certificate chain), it will try to match the server's leaf certificate hash with what's stored in the DB.
    • If it matches, great! Let the user in by ignoring SSL verification errors on the connection, and reconnecting.
    • It it doesn't match, present a dialog similar to the one they were presented with in the first place, but now telling them that the certificate hash of the server does not match the one stored on our DB.

We don't perform any validation of our own on the certificate chain once it's been marked as "trusted" by the user. Maybe we should. (Something that comes to mind is to verify that the notBefore date is not in the future before we store the cert in the DB, and to verify that the notAfter date isn't exceeded when silently connecting to "trusted" server...)

from mumble-iphoneos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.