1.1.2 Update Error

[murhafsousli]

1.1.2 Update Error

[MurhafSousli]

Fixed in 1.1.3

[tinesoft]

Hi @MurhafSousli ,

I have downloaded latest v1.1.2 and looked inside the installed package in my node_modules/ng2-sharebuttons folder. The problem is that it still contains the whole project structure, where as it should only contains what is inside 'dist' folder (conf. PR #19).

Did you publish using the new gulp task i've added in PR #19: gulp publish ?
Which prepare the 'dist' folder and them run npm publish on that folder.

You can also run gulp build and them npm publish ./dist

[MurhafSousli]

@tinesoft This can be solved by excluding directories in npmignore

I used npm run prepublish, and tried the compiled files in the demo and it works, then when I published to npm using gulp publish, I tested it in the demo again and I got that error

[tinesoft]

Hi,

you mean : npm run prepublish? (not gulp run prepublish)
If so, this command runs the default gulp task (see "scripts" section of package.json),
which build the dist folder.

Could you try my second proposition:

gulp build

then

npm publish ./dist from project root

I believe we shouldn't have to specify an .npmignore file because only the content of dist folder is supposed to be published to NPM, and it already contains just everything needed for the package...

[MurhafSousli]

@tinesoft sorry I meant npm run prepublish, okay I will try