Angular2 Universal support

[murhafsousli]

Angular2 Universal support

[MurhafSousli]

@u12206050 Yup, it uses window.open() to open the dialog, let me investigate this further for you

[u12206050]

The main problem is the use of window.location.href, I believe angular does have a Location object that you can use. Luckily window.open() doesn't get called when rendering on the server so that isn't such a big deal.

For others wanting to fix this, I did the following to fix the window.location.href:

Replaced window.location.href with
typeof window != 'undefined' ? window.location.href : typeof global != 'undefined' ? global.url : ''

And then in server.ts where Universal is being called to render do the following:

/* Declare both global and the url property for typescript concerns */
interface Global {
  url: string;
}
declare var global: Global;

/* In the function that responds with the rendered html */
let ngApp = (req, res) => {
  let url = req.originalUrl || '/';
  global.url = url;

  ...
}

[MurhafSousli]

@u12206050 I got it, it turned out that there's no window in node, @ViewChild('firstModal') could be a solution

[u12206050]

Is this fixed now?

[MurhafSousli]

@u12206050 I haven't played with Universal yet, but now sharebuttons will only use window.location.href if the [url] input is not provided, so pass your current url to the input and it should work

[MurhafSousli]

@u12206050 For opening share window which uses window.open I'm not sure if it can be fixed in Universal, I talked about it in angular group

I would have used a modal instead of window,open, but fb have SAMEORIGIN policy, which disallows sharing within iframe outside of their domain..

[u12206050]

Could you just please do the following, it fixes compiling on universal side at least.
Replaced window.location.href with
typeof window != 'undefined' ? window.location.href : typeof global != 'undefined' ? global.url : ''

[MurhafSousli]

@u12206050 okay it's merged now, please download the source manually and test it in your app, if it works I will push it to npm, because I'm not sure if it would work with window.open. isn't it a problem for universal to compile?

btw, I tried to replace window.location.href with router.url, location.path() and location.prepareExternalUrl(location.path()), they all don't return the full path, also couldn't find any alternative to window.open. we can't get rid of it

[u12206050]

Ok, the changes should work, except that window and global are undefined in the context of typescript when compiling. I made a merge request with the interfaces for them.

[MurhafSousli]

I tried to use it on a fresh Universal Starter installation, I imported ShareButtonsModule in both app.browser.module and app.node.module, it worked.
The only issue I found is when I click on Pinterest button. Cannot read property 'getAttribute' of null, but everything else is working as expected!
BTW this is without the changes we made earlier 👆

[MurhafSousli]

Changes are merged and pushed to npm in 1.0.7

[u12206050]

Did you make use of the share buttons on universal side or do you only render them client side?

[MurhafSousli]

Did you make use of the share buttons on universal side

@u12206050 I just used it the same way I would use it in a normal angular app and it worked, I'm not sure what you mean by make use of them on universal side because I'm not technically familiar with universal yet. I have been told that global variables like window are not available in node apps, and we can't get rid of window completely since there is no other way to open the sharing dialog in a new window (not new tab).