Giter Site home page Giter Site logo

Comments (14)

musselwhizzle avatar musselwhizzle commented on June 12, 2024

Awesome. Thanks. Would you mind attaching a raw file for me so I can see the metadata and play around with this? The code will most likely need some updates as I don't think "33" is a valid property type. I'll work on adding it for you though.

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

You can take any files from dpreviews studio scene comparison, such as this JPG here: https://www.dpreview.com/reviews/image-comparison/download-image?s3Key=6f225c8c22ca48c9bc25c582f9981382.jpg where the center point was chosen.

On Pentax DSLRs the AF points actually always are named by a simple number such as "1" or "5" or "33", where on Nikon you have the "A1" and "D8" and so on. The num,bering scheme also is quite simple on all models since they always start the "1" on the top row left corner and increment as you read to the right and down. See Phil Harveys documentation here: http://exiftool.sourceforge.net/TagNames/Pentax.html

On a more general note I suggest for a later release you consider a routine to adjust things if the used creates a JPG with a resolution lower than maximum, e.g. 16 MPx instead of 36 MPx. The absolute pixelcounting currently suggests it works only on uncropped full res images.

Thanks for your great work.

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

By the way, I got to the data in a quick way:

  1. Google for a viewfinder overlay image for your camera, such as this one: https://1.bp.blogspot.com/-DRWu2YmqHcg/UeNOnX0OtjI/AAAAAAAABaU/68Oz7X-Svf0/s1600/Nikon+D7100+AF.jpg
  2. Show it on your computer screen screen maximised
  3. Take one JPG image of your computer screen with your camera where you frame it exactly fitting
  4. Display your photo JPG in a viewer like XnView which does show the exact mouse pointer coordinates
  5. just point the mouse over each AF point and take a note of this

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

And here are more raws and full metadata images to play around with:
http://www.imaging-resource.com/PRODS/pentax-k1/pentax-k1GALLERY.HTM
and
http://www.photographyblog.com/previews/pentax_k1_photos/
and
https://www.dpreview.com/samples/8631711489/pentax-k-1-real-world-sample-gallery
and
http://www.d-pixx.de/2016/07/pentax-k-1-test/
and

from focus-points.

musselwhizzle avatar musselwhizzle commented on June 12, 2024

until i have a chance to test it, you can take a look here and see if it works as expected.
https://github.com/musselwhizzle/Focus-Points/tree/feature/pentax

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

Hm. I do get an error 1 as it says, the plug-in is for LR v6 only.
I only have LR v5.7.1 here.
Is the plug-in really dependend on v6 specific functionality? That might exclude quite a number of people from using it.

from focus-points.

musselwhizzle avatar musselwhizzle commented on June 12, 2024

i lowered the required version to 5. download again and try. Let me know if the whole application still works. I only have LR 6 so I can't test.

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

Thanks. I now can start the plugin. But when calling it I get an error pop-up:
"Internal error. Couldn't open file [image]-metadata.txt for reading."
Running Windows 7 64bit if that has any impact.

from focus-points.

musselwhizzle avatar musselwhizzle commented on June 12, 2024

Would you download this version which has logging enabled:
https://github.com/musselwhizzle/Focus-Points/tree/feature/windows_path

and paste the logs in here. According to the docs, the log is located in "your My Documents folder."

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

Thanks, I will run that in a minute. First I would like to share something I found on Adobe forums, which might be helpful here as it is about funny LR Lua syntax:

on Windows systems, LrTasks.excecute() is tricky:

  • substitute \ by \\ (this is a Lua issue)
  • surround each pathname that has a space in it with double-quotes (")
  • substitute > by ^>
  • in addition, surround the whole commandline with double-quotes

Besides that your program path doesn't look correct. It should be:
C:\programs\dcrawps64.exe
and therefore in your Lua code, you have to use:
C:\\programs\\dcrawps64.exe

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

The only log file I found after installing your new version is "libraryLogger.log" and it contains three lines:

01/05/2017 11:27:13 WARN starting plugin
01/05/2017 11:27:13 WARN writing metadata file to: E:\85 Downloads\K_1_1502-metadata.txt
01/05/2017 11:27:13 WARN exif command: 'C:\Programme_Portabel\LR-Plugins\focuspointswin.lrplugin\bin\exiftool\exiftool' -a -u -g1 'E:\85 Downloads\K_1_1502.JPG' > 'E:\85 Downloads\K_1_1502-metadata.txt'

No file of the name "K_1_1502-metadata.txt" is on the drive.

from focus-points.

musselwhizzle avatar musselwhizzle commented on June 12, 2024

Ok thank you. Some people are working on the issue over here on this ticket. #11 (comment)

I'm confident it'll be figured out soon :)

from focus-points.

Knubbel avatar Knubbel commented on June 12, 2024

Cool. Just give a message, once that is solved.

from focus-points.

musselwhizzle avatar musselwhizzle commented on June 12, 2024

windows is kind of resolved-ish. It's the best it's going to get for now (which is no good....)
If you're able to verify the plugin at least attempts to put the focus spots in the right place, that would be great.

from focus-points.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.