Cropped on a Rotate 90 CW is incorrect focus point

[musselwhizzle]

Cropped on a Rotate 90 CW is incorrect focus point

[rderimay]

Please provide an example file / screen shot.

[musselwhizzle]

Error

crop shown

uncropped

[project802]

No crop or rotation:

Basic crop/rotation around the center point:

[rderimay]

Thanks will look at it.
The transformation code is anyway not clean for me.

No idea what I changed there to make it not work anymore. Maybe this is related to the new json decoding.

[musselwhizzle]

this is on current master.

[rderimay]

ah ok. better then.

[project802]

If you need it, the NEF from my example above is now in the Focus-Points-Sample-Images master.

[musselwhizzle]

@rderimay if you work on this, please work off of the current master and not any outstanding PRs. This is a separate issue, standalone. It can be merge into other things.

[rderimay]

Cannot make a new PR until PR #47 is accepted (or not) @musselwhizzle.
Should you just pick stuff, let me know what and what not please.

[musselwhizzle]

https://github.com/musselwhizzle/Focus-Points/blob/master/Contributing.md
The current flow is causing issues.

#47 is merged into a feature branch. It will not be in master for now. I suppose since it is already merged, reset your git to the current master "git checkout master; git fetch; git reset --hard origin/master" and that would work.

[musselwhizzle]

So my bug report is inaccurate and I'm going to close the ticket. Basically, originally the image was upside down and I (apparently) rotated it to turn it right side up. Since LR doesn't report rotations, the values are off.

I'm closing the ticket.

[project802]

The image I attached is straight out of the camera. Rotating it in LR shows the above error. New issue or reopen?

[project802]

Is #53 where this is now tracked?

[rderimay]

Yes, I will track this at the same time, I have to redo the math to accommodate the fact that a user can also rotate on grid

[musselwhizzle]

@project802 i reopened the issue and will help verify on your file. Can you please link directly to the RAW file for testing.

[musselwhizzle]

@rderimay - assume this is a non issue until we get the file and I can verify.

[project802]

I'm on mobile but the file is in the sample images under D800 and it's the portrait one. Just pulled in yesterday I think.

[musselwhizzle]

i dont see any sample images:
https://github.com/musselwhizzle/Focus-Points-Sample-Images/tree/master/Canon

[project802]

https://github.com/project802/Focus-Points-Sample-Images/blob/master/Nikon/D800/D800-C9-90deg.NEF

[musselwhizzle]

Verified, but let me make a separate ticket since it's a bit different. Once specific to this issue.

[musselwhizzle]

#55