Keisei breaks Tampermonkey Scripts

[mwil]

Keisei breaks Tampermonkey Scripts

[mwil]

I haven't noticed an issue yet, and there are no other reports of this issue. What OS, browser, Tampermonkey version are you using? Tampermonkey 4.7 for Chrome was released not too long ago.

When you have several script activated with Keisei, does Keisei work while nothing else works, or nothing at all works? What order of scripts are you using? And which other scripts fail?

There was an issue with another script of mine (Niai) because of some weird interaction of a Tampermonkey feature, but that was fixed (https://community.wanikani.com/t/userscript-wip-lock-script/24510/4).

I don't know what breaks for you, but I suspect that it is somehow related to Tampermonkey is acting strangely.

[Koolstr]

This is on Firefox, with Tampermonkey v4.8.5847. I've just tried enqueuing Keisei to run first out of all userscripts, but the problem persists. The problem remains even if it is the only script enabled.

This problem arose seemingly around the same time I updated to the latest version of Firefox. Perhaps look into that?

[mwil]

I tested on OSX and Windows on Firefox 62.0.2, Tampermonkey v4.8.5847, it is still working for me.

Is there any console output when you just use Keisei (Ctrl-Shift-K or Cmd-Opt-K)? Also, you can try to set Tampermonkey's Logging Level in Tampermonkey's Settings > General to Debug, it gives hopefully more hints what is causing this.

Are you using some specific security solution that might block Tampermonkey? Keisei uses advanced Tampermonkey features like reading styles from resource files that maybe no other userscript is using, and this might trigger a blocking reaction of the whole Tampermonkey.

[mwil]

I haven't found the source for this yet, but it must be within the recent changes.

For now you can downgrade to v1.6.7, this fixed the problem for other FF users. Downgrade link

[mwil]

I think I found the source for this problem, GM_getValue() completely trips Firefox when used with the optional default value.

Version 1.7.3 should fix your issue.

Please feel free to open another issue if this issue still persists for you.

[Koolstr]

Indeed, that seemed to be the issue. It works now. Thank you so much for being on top of this and fixing it!

[Koolstr]

The same problem now occurs for the Niai script as well. Please patch it there too.